Skip to content

Fix performance regression on instant-execution #9613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 3, 2019
Merged

Fix performance regression on instant-execution #9613

merged 6 commits into from
Jun 3, 2019

Conversation

bamboo
Copy link
Member

@bamboo bamboo commented Jun 3, 2019

By caching some key data structures:

  • the bean constructor used for deserialization per bean type
  • the bean field schema per bean type
  • the bean field assignment strategy per bean field
  • the encoding strategy per type

After the optimisations, instant-execution for compileJava in a 500 project build builder build is ~5x faster than classic execution and storing the task graph adds very little overhead.

image

bamboo added 3 commits June 3, 2019 13:33
@bamboo
Reduce memory usage for task classpath computation
54ead43 
By keeping a single set in memory during the whole computation.
@bamboo
Cache bean serialization constructor and schema when reading from ins…
cd01488 
…tant-execution cache

This optimisation more than makes up for the time lost restoring the
dynamically registered properties.
@bamboo
Cache instant-execution type encoding strategy
ba2abe6 
For a boost in write performance.
@bamboo bamboo added from:member in:configuration-cache Configuration Caching labels Jun 3, 2019
@bamboo bamboo self-assigned this Jun 3, 2019
bamboo added 3 commits June 3, 2019 14:32
@bamboo
Polish ClasspathUtil
3ebff15
@bamboo
Polish DefaultInstantExecution and Codecs
b8ec14a 
- Remove unused parameters
- Remove unused properties
- Rework method for clarity
@bamboo
Polish TaskGraphCodec
4819540 
- Remove redundant visibility modifiers
@bamboo bamboo merged commit 04cae2a into master Jun 3, 2019
@bamboo bamboo deleted the bamboo/ie/perf-regression branch July 2, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bamboo bamboo

Labels

in:configuration-cache Configuration Caching

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bamboo