Add gradlePluginPortal(Action<>) to RepositoryHandler #8802
Conversation
subprojects/core-api/src/main/java/org/gradle/api/artifacts/dsl/RepositoryHandler.java
Outdated
Show resolved
Hide resolved
subprojects/core-api/src/main/java/org/gradle/api/artifacts/dsl/RepositoryHandler.java
Outdated
Show resolved
Hide resolved
subprojects/core-api/src/main/java/org/gradle/api/artifacts/dsl/RepositoryHandler.java
Outdated
Show resolved
Hide resolved
c5aa9ec to
73dd42a
Compare
|
@ljacomet fixed and CI is 🍏 🤘 |
|
@StefMa Would you consider squashing your commits? Not sure the history is useful given the scope of the change. Wdyt? Then I would trigger a full build on our CI infra to make sure all is good. |
|
Sure I could do this.
But you can do this while merging as well ☺
See
https://help.github.com/en/articles/merging-a-pull-request#merging-a-pull-request-on-github
…On Mon, Mar 18, 2019, 4:52 PM Louis Jacomet ***@***.***> wrote:
@StefMa <https://github.com/StefMa> Would you consider squashing your
commits? Not sure the history is useful given the scope of the change. Wdyt?
Then I would trigger a full build on our CI infra to make sure all is good.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8802 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJwYewWJ9I-w1PFr4HpMexDRLTT2bLbpks5vX7YmgaJpZM4b51GG>
.
|
|
That's true, though I have no idea how it plays with our DCO check 😉 |
|
Let me trigger a full build now. |
|
Rebased and squashed everything ✅ This https://builds.gradle.org/viewLog.html?buildId=20995831&buildTypeId=Gradle_Check_Stage_ReadyforMerge_Trigger was failing on your CI. The other tests passed. But for whatever reasons I can't access it currently... |
|
How I can fix this issues? 🤔 |
|
My bad, forgot to leave a comment last week. The branch point you took was bad in the sense that it had a performance regression. It has been fixed since then. Thanks for your patience. |
Signed-off-by: Stefan M <[email protected]>
|
Rebased ✅
…On Mon, Mar 25, 2019, 3:16 PM Louis Jacomet ***@***.***> wrote:
My bad, forgot to leave a comment last week. The branch point you took was
bad in the sense that it had a performance regression. It has been fixed
since then.
A rebase of the branch on current master is your best course of action.
Thanks for your patience.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8802 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJwYe7s2FT-73QXjwzfIvvogdxqK7rJsks5vaNojgaJpZM4b51GG>
.
|
|
And merged, thanks for the contribution |
Context
This is a "follow up" of #8636
I think @ljacomet has just overseen the
gradlePluginPortal😅.I hope it is ok and break nothing to change the PluginPortal from a
ArtifactRepositoryto anMavenArtifactRepository. But since it is an "up cast" nothing should break ✊.I also have added the
@Incubatingbecause thegradlePluginPortal()have this as well...Changes in the
accepted-public-api-changes.json(like here) and in the "changelog" (here) should be done afterwards as well 👍Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective<subproject>/src/test) to verify logicUpdate User Guide, DSL Reference, and Javadoc for public-facing changesEnsure that tests pass locally:./gradlew <changed-subproject>:checkGradle Core Team Checklist