De-incubate all APIs pre Gradle 3.0 #7229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It did only depend on the location of the files but not the actual contents.
So that the incubation report task detects the version correctly.
34e65b3 to
6d4ca09
Compare
|
That brings down usages of |
adammurdoch
suggested changes
Oct 9, 2018
subprojects/core/src/main/java/org/gradle/deployment/internal/DeploymentRegistry.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Displays some details about the software components produced by the project. | ||
| */ | ||
| @Incubating |
There was a problem hiding this comment.
We shouldn't promote software model types.
There was a problem hiding this comment.
Not promoting software model types any more.
| * Displays some details about the configuration model of the project. | ||
| * An instance of this type is used when you execute the {@code model} task from the command-line. | ||
| */ | ||
| @Incubating |
| * | ||
| * <p>NOTE: This currently supports configuring the 'idea' plugin only.</p> | ||
| */ | ||
| @Incubating |
There was a problem hiding this comment.
I probably wouldn't promote the play stuff yet, as it depends on the software model.
There was a problem hiding this comment.
Not promoting play any more.
| /** | ||
| * A set of sources passed to the Java compiler. | ||
| */ | ||
| @Incubating |
| /** | ||
| * A set of resource files. | ||
| */ | ||
| @Incubating |
| * Plugin for packaging JVM resources. Applies the {@link org.gradle.language.base.plugins.ComponentModelBasePlugin}. Registers "resources" language support with the {@link | ||
| * org.gradle.language.jvm.JvmResourceSet}. | ||
| */ | ||
| @Incubating |
This has been around since 2013.
This is an internal API
Some of those are part of the software model, but we still use it in the current model tasks.
6d4ca09 to
a5932e2
Compare
|
Diff of incubating report before and after the PR as it is now: https://gist.github.com/lptr/be9438bf3684eb8f3bdce2af3401e815 |
lptr
requested changes
Oct 10, 2018
subprojects/testing-jvm/src/main/java/org/gradle/jvm/plugins/JUnitTestSuitePlugin.java
Show resolved
Hide resolved
...in/kotlin/org/gradle/gradlebuild/buildquality/incubation/IncubatingApiAggregateReportTask.kt
Show resolved
Hide resolved
subprojects/language-jvm/src/main/java/org/gradle/language/jvm/JvmResourceSet.java
Show resolved
Hide resolved
subprojects/platform-jvm/src/main/java/org/gradle/jvm/toolchain/JavaToolChain.java
Show resolved
Hide resolved
...jects/language-scala/src/main/java/org/gradle/language/scala/tasks/AbstractScalaCompile.java
Show resolved
Hide resolved
subprojects/core/src/main/java/org/gradle/deployment/internal/DeploymentRegistry.java
Outdated
Show resolved
Hide resolved
...iagnostics/src/main/java/org/gradle/api/reporting/dependencies/HtmlDependencyReportTask.java
Outdated
Show resolved
Hide resolved
|
@lptr PTAL. |
|
I see |
That is a software model plugin.
|
@lptr See #7229 (comment) |
|
That link doesn't do anything. :o |
|
Found it. LGTM. |
lptr
approved these changes
Oct 10, 2018
|
Wait, |
That is a software model report.
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without anything from the software model.