Convert all remaining JMock tests to Spock #6949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
reviewed
Sep 30, 2018
| testFixturesApi(testLibrary("spock")) | ||
| testFixturesRuntimeOnly(testLibrary("bytebuddy")) | ||
| testLibraries("jmock").forEach { testFixturesApi(it) } | ||
| testFixturesRuntimeOnly(testLibrary("cglib")) |
There was a problem hiding this comment.
Why do we still need cglib?
There was a problem hiding this comment.
It's required when deserializing custom actions in Tooling API tests. I didn't get to the point of understanding why.
I suspect that this dependency isn't in quite the right place, but it was the minimal change I needed to make for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were causing many deprecation warnings to be emitted in IDEA when building, so I finally converted the last remaining ones over.