Provide a typesafe API for configuring pattern layout #6616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61b1bc6 to
7d78d80
Compare
eskatos
reviewed
Sep 5, 2018
| * @since 2.3 (feature was already present in Groovy DSL, this particular method introduced in 2.3) | ||
| * @deprecated use {@link #layout(String)} or {@link #patternLayout(Action)} | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
❓ shouldn't the now deprecated methods implementations nag?
melix
suggested changes
Sep 6, 2018
7d78d80 to
4c5f545
Compare
4b5f0e1 to
4067b6a
Compare
When an IvyArtifactRepository is configured with a `pattern` layout, it can be further configured. This change deprecates the older method that took both the layout name and a configuration closure in favour of a named method to configure the `pattern` layout since the others cannot be configured. Issue #6529
This test triggers a deprecation warning as the Kotlin DSL needs to
remove the usage of `layout("pattern") {`. BUt the warning does not
appear all the time, so I had to disable checking altogether.
4067b6a to
4dadf84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an IvyArtifactRepository is configured with a
patternlayout, itcan be further configured. This change deprecates the older method that
took both the layout name and a configuration closure in favour of a
named method to configure the
patternlayout since the others cannotbe configured.