Preliminary Play 2.7 support #6374

raboof · 2018-08-14T09:36:12Z

Testing with 2.7.0-M2 now, not thoroughly tested yet though.

Context

Resolve issue #6362

Contributor Checklist

Review Contribution Guidelines
Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
Provide unit tests (under <subproject>/src/test) to verify logic
Update User Guide, DSL Reference, and Javadoc for public-facing changes
Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

Verify design and implementation
Verify test coverage and CI build status
Verify documentation
Recognize contributor in release notes

With akka-grpc from the akka/akka-grpc#302 branch and gradle from the gradle/gradle#6374 branch

marcospereira

Looking good so far. Need to change tests too.

marcospereira · 2018-08-15T15:21:06Z

...jects/platform-play/src/main/java/org/gradle/play/internal/routes/RoutesCompilerFactory.java

Just add another case without repeting the RoutesCompilerAdapterV24X creatiion:

case PLAY_2_6_X: case PLAY_2_7_X: return new RoutesCompilerAdapterV24X(playVersion, scalaVersion);

subprojects/platform-play/src/main/java/org/gradle/play/internal/platform/PlayMajorVersion.java

marcospereira · 2018-08-15T15:22:15Z

...rojects/platform-play/src/main/java/org/gradle/play/internal/twirl/TwirlCompilerFactory.java

marcospereira · 2018-08-15T15:31:17Z

@raboof you can see how tests had changed for Play 2.6 here: #3018.

raboof · 2018-08-20T15:48:14Z

I made some updates, but the integration tests fail because they rely on StaticRoutesGenerator which was deprecated in 2.6.0 and now removed in 2.7.0. How should we handle this? Rewrite the tests with InjectedRoutesGenerator, or would that fail with older versions of Play?

marcospereira · 2018-08-20T19:10:36Z

How should we handle this? Rewrite the tests with InjectedRoutesGenerator, or would that fail with older versions of Play?

Hum... InjectedRoutesGenerator was introduced in Play 2.4 and Gradle supports Play from 2.3 to 2.6 right now. That means you cannot just change to InjectedRoutesGenerator because that will make 2.3 fails (I'm not so sure about how Gradle handles this though).

Is it possible to isolate the tests for 2.7 to force the use of InjectedRoutesGenerator? Or better, make it the default for 2.7 even if it is
configured to do the opposite (and log a warning). Another idea is to remove Play 2.3 support since this version of Play is not maintained anymore and then use InjectedRouterGenerator as you suggested, @raboof.

@blindpirate @marcphilipp WDYT?

raboof · 2018-08-23T07:35:49Z

The newest version in the play 2.3 series was released back in 2015... feels like it might be OK to drop support for it? Or do we need to go through a deprecation cycle for that first?

marcphilipp · 2018-09-03T09:11:23Z

Removal of 2.3 needs a proper deprecation cycle to be removed with Gradle 6.0.

@raboof Could you please post an example of such a problematic test?

octonato

Play 2.7.0-RC3 is released, so I updated the references to M2

subprojects/platform-play/src/main/java/org/gradle/play/internal/platform/PlayMajorVersion.java

...tform-play/src/integTest/groovy/org/gradle/play/integtest/PlayPlatformIntegrationTest.groovy

...jects/platform-play/src/test/groovy/org/gradle/play/internal/PlayPlatformResolverTest.groovy

...ects/platform-play/src/test/groovy/org/gradle/play/plugins/PlayDistributionPluginTest.groovy

...platform-play/src/testFixtures/groovy/org/gradle/play/integtest/fixtures/PlayCoverage.groovy

...rojects/platform-play/src/main/java/org/gradle/play/internal/twirl/TwirlCompilerFactory.java

marcospereira · 2019-02-01T22:15:03Z

...ects/platform-play/src/test/groovy/org/gradle/play/plugins/PlayDistributionPluginTest.groovy

Suggested change

"2.7.0-RC3" | "play.core.server.ProdServerStart"

"2.7.0" | "play.core.server.ProdServerStart"

marcospereira · 2019-02-01T22:17:14Z

...platform-play/src/testFixtures/groovy/org/gradle/play/integtest/fixtures/PlayCoverage.groovy

Code format got a little weird here.

Testing with 2.7.0-M2 now, not thoroughly tested yet though. Signed-off-by: Arnout Engelen <[email protected]>

Signed-off-by: Arnout Engelen <[email protected]>

Unfortunately this will fail because some tests rely on StaticRoutesGenerator which was deprecated in 2.6.0 and removed in 2.7.0 https://github.com/playframework/playframework/blob/a2186e10178f7084c9493ecc8246b615bf108371/documentation/manual/releases/release27/migration27/Migration27.md#staticroutesgenerator-removed Signed-off-by: Arnout Engelen <[email protected]>

Signed-off-by: Renato Cavalcanti <[email protected]>

marcospereira · 2019-02-07T20:30:51Z

@marcphilipp @blindpirate,

I think this is now complete and good to review/merge. It is not removing Play 2.3 anymore so that it does not need to go through the deprecation cycle.

WDYT?

adcalder7 · 2019-03-22T22:17:19Z

Please merge.

octonato · 2019-03-25T08:15:31Z

@big-guy / @marcphilipp, is there anything missing to get this merged?

big-guy · 2019-03-25T20:18:21Z

@renatocaval We want to get this in, but we're also trying to extract the Play plugin into a separately releasable plugin: https://github.com/gradle/playframework We're not going to get to this PR for the next release (5.4), but I want to circle back on this for the following release.

dwijnand · 2019-05-14T07:59:38Z

From #6362 (comment) it seems the new plan is to migrate/port, not merge this PR.

lacasseio · 2019-05-14T08:17:05Z

We may merge this as-is but the expectation should be to migrate to gradle/playframework. At the moment, this plugin is simply the extraction of the play plugin from the Gradle core to use the current model instead of the software model.

arjunchhabra · 2019-09-11T16:39:29Z

@lacasseio - Any update on this item? Whether extracting or merging here, I believe many of us are currently without a path forward.

lacasseio · 2019-09-12T11:28:40Z

@arjunchhabra Let's migrate the change to gradle/playframework.

For everyone wanting this to be part of the core plugin, let's instead focus on identifying the blocker preventing you from migrating to the gradle/playframework by opening issues over there. We won't be waiting long before the deprecation cycles starts for this core plugin.

big-guy · 2019-09-17T06:02:29Z

I'm going to close this as the playframework plugin has these changes now and should be released shortly.

marcphilipp added in:play a:feature A new functionality labels Aug 14, 2018

raboof mentioned this pull request Aug 14, 2018

Play code generation from gradle akka/akka-grpc#302

Merged

raboof force-pushed the play27 branch from 211a85e to 5cd1f1d Compare August 14, 2018 12:59

raboof added a commit to raboof/akka-grpc-play-quickstart-java that referenced this pull request Aug 14, 2018

WiP Gradle support

91317e2

With akka-grpc from the akka/akka-grpc#302 branch and gradle from the gradle/gradle#6374 branch

raboof added a commit to raboof/akka-grpc-play-quickstart-java that referenced this pull request Aug 14, 2018

WiP Gradle support

cdad93c

With akka-grpc from the akka/akka-grpc#302 branch and gradle from the gradle/gradle#6374 branch

raboof mentioned this pull request Aug 14, 2018

Towards Gradle support playframework/play-java-grpc-example#11

Open

marcospereira reviewed Aug 15, 2018

View reviewed changes

octonato approved these changes Nov 15, 2018

View reviewed changes

octonato force-pushed the play27 branch from 8a42029 to 46a1c94 Compare February 1, 2019 15:34

marcospereira reviewed Feb 1, 2019

View reviewed changes

raboof mentioned this pull request Feb 2, 2019

Playframework 2.7 support #6362

Closed

raboof added 4 commits February 5, 2019 09:58

Preliminary Play 2.7 support

1e770e4

Testing with 2.7.0-M2 now, not thoroughly tested yet though. Signed-off-by: Arnout Engelen <[email protected]>

PlayRunAdapterV27X extends PlayRunAdapterV26X

f027d6d

Signed-off-by: Arnout Engelen <[email protected]>

Use case fallthrough

080ea87

Signed-off-by: Arnout Engelen <[email protected]>

raboof force-pushed the play27 branch from 46a1c94 to 7265ed2 Compare February 5, 2019 08:58

octonato added 2 commits February 7, 2019 14:28

Update to Play 2.7.0

562c82c

Signed-off-by: Renato Cavalcanti <[email protected]>

formatting

d316a63

Signed-off-by: Renato Cavalcanti <[email protected]>

octonato force-pushed the play27 branch from c0e4bb7 to d316a63 Compare February 7, 2019 13:29

using Play 2.7.0 in PlayDistributionPluginTest

4c4fb10

Signed-off-by: Renato Cavalcanti <[email protected]>

big-guy added this to the 5.4 RC1 milestone Feb 12, 2019

big-guy added the @core Issue owned by GBT Core label Mar 4, 2019

big-guy modified the milestones: 5.4 RC1, 6.0, 6.0 RC1 Mar 11, 2019

arjunchhabra mentioned this pull request Sep 16, 2019

Preliminary Play 2.7 Support gradle/playframework#110

Merged

big-guy closed this Sep 17, 2019

ov7a removed this from the 6.0 RC1 milestone Mar 28, 2024

	"2.7.0-RC3" \| "play.core.server.ProdServerStart"
	"2.7.0" \| "play.core.server.ProdServerStart"

Preliminary Play 2.7 support #6374

Preliminary Play 2.7 support #6374

Uh oh!

Conversation

raboof commented Aug 14, 2018

Context

Contributor Checklist

Gradle Core Team Checklist

Uh oh!

marcospereira left a comment

Choose a reason for hiding this comment

Uh oh!

marcospereira Aug 15, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marcospereira Aug 15, 2018

Choose a reason for hiding this comment

Uh oh!

marcospereira commented Aug 15, 2018

Uh oh!

raboof commented Aug 20, 2018

Uh oh!

marcospereira commented Aug 20, 2018

Uh oh!

raboof commented Aug 23, 2018

Uh oh!

marcphilipp commented Sep 3, 2018

Uh oh!

octonato left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcospereira Feb 1, 2019

Choose a reason for hiding this comment

Uh oh!

marcospereira Feb 1, 2019

Choose a reason for hiding this comment

Uh oh!

marcospereira commented Feb 7, 2019

Uh oh!

adcalder7 commented Mar 22, 2019

Uh oh!

octonato commented Mar 25, 2019

Uh oh!

big-guy commented Mar 25, 2019

Uh oh!

dwijnand commented May 14, 2019

Uh oh!

lacasseio commented May 14, 2019

Uh oh!

arjunchhabra commented Sep 11, 2019

Uh oh!

lacasseio commented Sep 12, 2019

Uh oh!

big-guy commented Sep 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants