Do not close build cache service in buildFinished #4249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only did this so that we are able to observe the cleanup build operations. This should be handled differently: cleanup operations from caches should be seen as build operations automatically. By removing the `buildFinished` listener #4216 is fixed.
This was referenced Feb 2, 2018
lptr
approved these changes
Feb 2, 2018
9792d3f to
45d32ce
Compare
lptr
reviewed
Feb 2, 2018
| succeeds "build" | ||
| int buildSuccessful = output.indexOf("BUILD SUCCESSFUL") | ||
| int i1SecondBuild = output.indexOf(":i1:second:build") | ||
| int i1SecondBuild = output.indexOf(":included:second:build") |
| } | ||
| """ | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only did this so that we are able to observe the cleanup build operations.
This should be handled differently: cleanup operations from caches should be seen as build operations automatically.
By removing the
buildFinishedlistener #4216 is fixed.