dismissOnPull obeys shouldDismiss #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gordontucker any chance you could merge this and cut a release? |
|
Checking in on this again—would it be possible to get this into a new release? |
|
To anyone coming across this issue: we ended up forking the project and will maintain the fork going forward. https://github.com/Asana/FittedSheets/releases/tag/v2.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you say
vc.dismissOnPull = trueandvc.shouldDismiss { _ in false }, I expect the view controller not to be dismissed when I pull down. (This logic applies todismissOnOverlayTapalready.)This change makes that true. Before, the view controller would be hidden even if
shouldDismissreturnedfalse.