Skip to content

Add supportedInterfaceOrientations #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

Add supportedInterfaceOrientations #181

merged 1 commit into from
Oct 27, 2022

Conversation

MariyanskiDev
Copy link
Contributor

Hello there. In my app some screen supporting different interface orientation like:

override var supportedInterfaceOrientations: UIInterfaceOrientationMask {
        return UIDevice.current.userInterfaceIdiom == .pad ? .all : [.portrait, .portraitUpsideDown]
 }

So I faced with a problem that SheetViewController ignoring supportedInterfaceOrientations of a child

I thinks that should be fair enough if SheetViewController could inherit supported interface orientations of his child

@gordontucker gordontucker merged commit a13d429 into gordontucker:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gordontucker gordontucker gordontucker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MariyanskiDev @gordontucker