Add pagination to s3 lister #2037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default `ListObjectsV2()` returns the first 1000 objects matching the list parameters. Normally this is fine, as it supports up to 333 versions (1000 / 3 files in proxy-triplet). For modules with more versions, this is insufficient and must be upgraded to paginate.
There was a problem hiding this comment.
Pull Request Overview
This PR adds pagination support for S3 listings to ensure that all versions are returned when there are more than 333 versions.
- Introduces a paginator to iterate over all pages using the s3-v2 API.
- Aggregates versions from each page into a single slice.
Comments suppressed due to low confidence (1)
pkg/storage/s3/lister.go:36
- [nitpick] Consider using the built-in 'append' function to concatenate slices, which is more idiomatic in Go and may offer better performance compared to slices.Concat.
versions = slices.Concat(versions, extractVersions(loo.Contents))
manugupt1
approved these changes
Apr 1, 2025
nrwiersma
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
ListObjectsV2()returns the first 1000 objects matching the list parameters.Normally this is fine, as it supports up to 333 versions (1000 / 3 files in proxy-triplet). For modules with more versions, this is insufficient and must be upgraded to paginate.
What is the problem I am trying to address?
Athens
/listendpoint returning a partial response when used with the s3backer and many (>333) versions.
How is the fix applied?
Using the paginator provided with the s3-v2 API for list queries.
What GitHub issue(s) does this PR fix or close?
N/A (I haven't made or seen one).