Skip to content

Fix docker workflow #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dometto wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix docker workflow #2147

dometto wants to merge 3 commits into from
+24 −15

Conversation

@dometto
Copy link
Member

@dometto dometto commented Aug 26, 2025

No description provided.

@dometto
Update tag pattern for Docker workflow triggers
49e0f3b 
Workflow was not running because `on: tag` is not valid in github actions (needs to be `on: push: tag`).
@dometto dometto force-pushed the dometto-patch-2 branch 2 times, most recently from 4949f20 to 1c86d60 Compare August 27, 2025 08:11
@dometto
Copy link
Member Author

dometto commented Aug 27, 2025

Sadly this doesn't quite work yet.

The first two commits in this PR solve two separate issues (the workflow not being triggered, and the build failing). The third commit attempts to fix a third issue: docker run is not working because the image name/tag is not being interpolated correctly -- it is empty, but should be gollumwiki/gollum:sha-<sha_of_the_build>. I've not solved this yet. I won't have time to work on this for a bit, so feel free to add to this PR and merge if anyone has an idea how to fix!

@benjaminwil benjaminwil force-pushed the dometto-patch-2 branch 3 times, most recently from a6ae43b to c697432 Compare August 27, 2025 18:14
@benjaminwil
Copy link
Member

benjaminwil commented Aug 27, 2025

I made some progress:

  • the docker run command is now working and running against the image built as part of the workflow.

Unfortunately:

  • The browser cannot access the Gollum server running at GOLLUM_CAPYBARA_URL anymore for some reason. I tried changing 127.0.0.1 to 0.0.0.0, but there are still access errors. Will post an excerpt below.

I expect the remaining issue is very simple to resolve, but I am out of time for today.

Excerpt: every test run as part of the workflow now fails this way:

Error:
Frontend_with_katex#test_no_unexpected_errors_on__Riddles:
Selenium::WebDriver::Error::UnknownError: unknown error: net::ERR_CONNECTION_REFUSED
  (Session info: chrome=139.0.7258.127)
    vendor/bundle/ruby/3.2.0/gems/selenium-webdriver-4.35.0/lib/selenium/webdriver/remote/response.rb:63:in `add_cause'
    vendor/bundle/ruby/3.2.0/gems/selenium-webdriver-4.35.0/lib/selenium/webdriver/remote/response.rb:41:in `error'
    vendor/bundle/ruby/3.2.0/gems/selenium-webdriver-4.35.0/lib/selenium/webdriver/remote/response.rb:52:in `assert_ok'
    vendor/bundle/ruby/3.2.0/gems/selenium-webdriver-4.35.0/lib/selenium/webdriver/remote/response.rb:34:in `initialize'
    vendor/bundle/ruby/3.2.0/gems/selenium-webdriver-4.35.0/lib/selenium/webdriver/remote/http/common.rb:103:in `new'
    vendor/bundle/ruby/3.2.0/gems/selenium-webdriver-4.35.0/lib/selenium/webdriver/remote/http/common.rb:103:in `create_response'
    vendor/bundle/ruby/3.2.0/gems/selenium-webdriver-4.35.0/lib/selenium/webdriver/remote/http/default.rb:103:in `request'
    vendor/bundle/ruby/3.2.0/gems/selenium-webdriver-4.35.0/lib/selenium/webdriver/remote/http/common.rb:68:in `call'
    vendor/bundle/ruby/3.2.0/gems/selenium-webdriver-4.35.0/lib/selenium/webdriver/remote/bridge.rb:625:in `execute'
    vendor/bundle/ruby/3.2.0/gems/selenium-webdriver-4.35.0/lib/selenium/webdriver/remote/bridge.rb:119:in `get'
    vendor/bundle/ruby/3.2.0/gems/selenium-webdriver-4.35.0/lib/selenium/webdriver/common/navigation.rb:32:in `to'
    vendor/bundle/ruby/3.2.0/gems/capybara-3.40.0/lib/capybara/selenium/driver.rb:95:in `visit'
    vendor/bundle/ruby/3.2.0/gems/capybara-3.40.0/lib/capybara/session.rb:281:in `visit'
    vendor/bundle/ruby/3.2.0/gems/capybara-3.40.0/lib/capybara/dsl.rb:52:in `call'
    vendor/bundle/ruby/3.2.0/gems/capybara-3.40.0/lib/capybara/dsl.rb:52:in `visit'
    test/integration/test_js_errors.rb:29:in `block (2 levels) in <top (required)>'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dometto @benjaminwil