TestEdgeQueryMultiFace: Simplify test #250
Open
+35
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c4fd9d to
cdb7b98
Compare
We always expect to find all locations, so just check for them
rather than comparing to the brute-force implementation.
(I guess we could loop and check both.)
Remove `struct{ latitude, longitude float64 }` repetition with
a `loc` type definition.
Add missing/extra ids to error output.
cdb7b98 to
d1af2d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always expect to find all locations, so just check for them rather than comparing to the brute-force implementation. (I guess we could loop and check both.)
Remove
struct{ latitude, longitude float64 }repetition with aloctype definition.