Enable glob syntax (/...) in ignored packages #709
Conversation
cf5739a to
b17acda
Compare
|
This PR enables using golang glob syntax ( Local package path in External package path would remain the same, like The locally ignored packages are not used as inputs for generating inputs-digest at the moment. Should we? I see |
Change gps.RootManifest.IgnoredPackages() to receive gps.SolveParameters. Use the SolveParameters's RootDir and RootPackageTree to ignore packages from root of the project.
Improves handling of ignored local packages. Adds tests for ignoring local packages. - ensure/empty/case4 for ignoring local packages with glob - ensure/empty/case5 for ignoring a single local package, but not subpackages
b17acda to
024505e
Compare
| return m.ovr | ||
| } | ||
| func (m simpleRootManifest) IgnoredPackages() map[string]bool { | ||
| func (m simpleRootManifest) IgnoredPackages(SolveParameters) map[string]bool { |
There was a problem hiding this comment.
Whatever route we take to accomplishing this goal, this interface needs to remain unchanged. In particular, we don't want to muddy the waters around SolveParameters by reusing it in this way.
|
I'll try some more and see if there's a way to do this. @sdboyer regarding the syntax for ignoring local packages, do we go for relative path or, full import path ? I think right now it works with full import path. |
|
sorry for long delay - definitely gonna be the full import path. also, i think that |
|
uggghhh i forgot this is here. making a TODO to pick it back up. |
|
Closing this in favor of #1156 |
Change gps.RootManifest.IgnoredPackages() to receive gps.SolveParameters.
Use the SolveParameters's RootDir and RootPackageTree to ignore
packages from root of the project.
Fixes #691