Skip to content

output: add colored-tab #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2023
Merged

output: add colored-tab #3729

merged 3 commits into from
Apr 3, 2023

Conversation

@ldez
Copy link
Member

@ldez ldez commented Mar 25, 2023

This PR introduces 2 changes:

  • remove the color of the tab output
  • add a new output colored-tab

I introduce a new colored-tab instead of no-color-tab to be homogeneous with line-number and colored-line-number.

I think that the removal of the color is a minor change because I don't see in which context it can be breaking.

Fixes #3728

@ldez ldez added enhancement New feature or improvement area: output Related to issue output labels Mar 25, 2023
@ldez ldez mentioned this pull request Mar 25, 2023
Closed
@ldez ldez force-pushed the feat/colored-tab branch from 8cad751 to a4498b3 Compare March 25, 2023 11:19
@cristaloleg
Copy link
Contributor

Works as expected, thanks for the quick PR !

@cristaloleg
Copy link
Contributor

I assume it's ok to slightly break compatibility. JFI

@ldez ldez force-pushed the feat/colored-tab branch 4 times, most recently from e9ad2c1 to 14ece63 Compare March 25, 2023 12:36
@ldez ldez assigned bombsimon and unassigned bombsimon Apr 2, 2023
@ldez ldez requested a review from bombsimon April 2, 2023 13:41
bombsimon
bombsimon approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice tests

@ldez ldez force-pushed the feat/colored-tab branch from 14ece63 to c5cb0a7 Compare April 3, 2023 23:42
@ldez ldez merged commit 00d17cc into golangci:master Apr 3, 2023
@ldez ldez deleted the feat/colored-tab branch April 3, 2023 23:57
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez @SeigeC
output: add colored-tab (golangci#3729)
9076872
@ldez ldez added this to the v1.53 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bombsimon bombsimon bombsimon approved these changes

+1 more reviewer

@cristaloleg cristaloleg cristaloleg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: output Related to issue output enhancement New feature or improvement

Projects

None yet

Milestone

v1.53

Development

Successfully merging this pull request may close these issues.

Tab output format without a color

3 participants

@ldez @cristaloleg @bombsimon