build(deps): bump github.com/nunnatsa/ginkgolinter from 0.8.1 to 0.9.0 #3643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
reviewed
Mar 1, 2023
415a158 to
00dfddc
Compare
ldez
requested changes
Mar 2, 2023
ginkgolinter version v0.9.0 brings two new rules. Both rules can be disabled from the configuration. This PR bumps the ginkgolinter to v0.9.0 and add the new configurations. The two new rules are: * haveLen(0) rule: `HaveLen(0)` ==> `BeEmpty()` * wrong comparison rule: `Expect(x == y).To(BeTrue())` ==> `Expect(x).To(Equal(y))` Full details are in the ginkgolinter README.md file, here: https://github.com/nunnatsa/ginkgolinter#readme.
00dfddc to
e81593a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ginkgolinter version v0.9.0 brings two new rules. Both rules can be disabled from the configuration.
This PR bumps the ginkgolinter to v0.9.0 and adds the new configurations.
nunnatsa/ginkgolinter@v0.8.1...v0.9.0
The two new rules are:
HaveLen(0)==>BeEmpty()Expect(x == y).To(BeTrue())==>Expect(x).To(Equal(y))The two new configurations are:
allow-havelen-zero- to not trigger warnings for the HaveLen(0) rulesuppress-compare-assertion- to not trigger warnings for the wrong comparison rule.Full details are in the ginkgolinter README.md file, here: https://github.com/nunnatsa/ginkgolinter#readme.