Skip to content

Conversation

black-06
Copy link
Contributor

@black-06 black-06 commented Feb 7, 2023

Skip go command because we can't add //nolint to the go command line.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 7, 2023

Hey, thank you for opening your first Pull Request !

@ldez ldez added the linter: update Update the linter implementation inside golangci-lint label Feb 7, 2023
@ldez ldez self-requested a review February 7, 2023 08:14
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just exclude all comments with the go directive prefix.

@ldez ldez added the bug Something isn't working label Feb 22, 2023
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 610a2bd into golangci:master Feb 22, 2023
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added this to the v1.52 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working linter: update Update the linter implementation inside golangci-lint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants