Upgrade depguard to fix performance issue with go modules #698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little insight on what I did. I timed depguard's
Runmethod using depguard's cli alone. Before the fix it took on average a minute to go through golangci-lint repository. This does not include the time it took to build the loader. With the new fix in place it takes on average 3 milliseconds.Before it was using go's build's context and the
Importmethod on that. This killed time as I think it was doing a lot more than what I really needed. Instead, I am using build's contextGOROOTand runningiotuil.ReadDirto get the prefix for all known root packages. And if there is one thing depguard was good at, it was efficiently looking up prefixes from a slice.Would love to hear your numbers as well.