linters: add Godox linter support #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jirfag merged 3 commits into golangci:master from matoous:md/add-godox

Sep 11, 2019

Contributor

matoous commented Jul 21, 2019

Godox is linter for TODOs and FIXMEs left in the code.

CLAassistant commented Jul 21, 2019 •

edited

Loading

All committers have signed the CLA.

matoous mentioned this pull request

[Feature] TODO/FIXME linter #547

Closed

Sean-Der reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

Sean-Der reviewed

View reviewed changes

README.md Show resolved Hide resolved

Sean-Der reviewed

View reviewed changes

README.md Show resolved Hide resolved

Sean-Der reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

Sean-Der reviewed

View reviewed changes

pkg/config/config.go Outdated Show resolved Hide resolved

Contributor Author

matoous commented Aug 21, 2019

Hey, I fixed the issues, can you review this once again @Sean-Der ? Thansk!

Contributor

jirfag commented Sep 10, 2019

Hi, thank you!
Didn't you forget to include golinters/godox.go file?

jirfag added the question label


          linters: add Godox linter support

a1ff275

Godox is linter for TODOs and FIXMEs left in the code.

Signed-off-by: Matous Dzivjak <[email protected]>

Contributor

jirfag commented Sep 10, 2019

also, it looks like that it should be rebased on the fresh master branch

Contributor Author

matoous commented Sep 10, 2019 •

edited

Loading

@jirfag everything is fixed I hope, can you check this PR ones again?

jirfag requested changes

View reviewed changes

pkg/config/config.go Outdated Show resolved Hide resolved

pkg/golinters/godox.go Show resolved Hide resolved

.golangci.example.yml Outdated Show resolved Hide resolved

.golangci.example.yml Outdated Show resolved Hide resolved

.golangci.yml Outdated Show resolved Hide resolved

test/testdata/godox.go Show resolved Hide resolved

go.mod Outdated Show resolved Hide resolved


          godox: Fix issues

7158e9c

jirfag reviewed

View reviewed changes

pkg/config/config.go Outdated Show resolved Hide resolved

vendor/modules.txt Outdated Show resolved Hide resolved


          godox: Remove unintended changes, remove unnecessary config

568f18a

Signed-off-by: Matous Dzivjak <[email protected]>

jirfag approved these changes

View reviewed changes

Contributor

jirfag left a comment

thank you very much!

jirfag merged commit 5884581 into golangci:master

Contributor

Sean-Der commented Sep 11, 2019

Great work @matoous 🎉 the second this comes out in a release I will start using it.

Good to see you back @jirfag, you are really doing a crazy amount of work :)

mgrachev mentioned this pull request

New check: TODO or FIXME dotenv-linter/dotenv-linter#175

Closed

ldez added linter: new and removed question labels

ldez added this to the v1.19 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels