Skip to content

build(deps): bump github.com/bombsimon/wsl/v5 from 4.7.0 to 5.0.0 #5900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldez merged 16 commits into from
Jun 28, 2025
Merged

build(deps): bump github.com/bombsimon/wsl/v5 from 4.7.0 to 5.0.0 #5900

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
da39e26
wsl: new v5
bombsimon Jun 28, 2025
f6f1bee
Bump to v5.0.0
bombsimon Jun 28, 2025
602a917
Update `WithSince`
bombsimon Jun 28, 2025
690b735
`go mod tidy`
bombsimon Jun 28, 2025
7396304
Drop unrelated changes from `linter_settings.go`
bombsimon Jun 28, 2025
cbf5261
Remove unused setting
bombsimon Jun 28, 2025
4aa0f49
chore: generate v2 configuration clone
ldez Jun 28, 2025
c190a14
chore: format
ldez Jun 28, 2025
86797cf
chore: lint
ldez Jun 28, 2025
6df4013
fix: wsl v5 needs types
ldez Jun 28, 2025
42c585f
tests: rename files
ldez Jun 28, 2025
307489b
tests: add wsl_v5 tests
ldez Jun 28, 2025
03bb402
chore: configuration and jsonschema
ldez Jun 28, 2025
17c167b
tests: fix configuration
ldez Jun 28, 2025
813a786
nitpick
ldez Jun 28, 2025
261caa0
nitpick
ldez Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests: fix configuration
  • Loading branch information
@ldez
ldez committed Jun 28, 2025
commit 17c167b7d51de13885520847c590ce4fd28fb946
4 changes: 2 additions & 2 deletions pkg/golinters/wsl/testdata/wsl_v5_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ package testdata

func fn1(s []string) {
a := "a"
s = append(s, a)
s = append(s, a) // want `missing whitespace above this line \(invalid statement above assign\)`

x := 1
s = append(s, "s") // want `missing whitespace above this line \(no shared variables above append\)`
s = append(s, "s") // want `missing whitespace above this line \(invalid statement above assign\)`

_ = x
}
12 changes: 6 additions & 6 deletions pkg/golinters/wsl/testdata/wsl_v5_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ version: "2"

linters:
settings:
wsl_v5:
allow-first-in-block: true
allow-whole-block: false
branch-max-lines: 2
case-max-lines: 0
default: all
wsl_v5:
allow-first-in-block: true
allow-whole-block: false
branch-max-lines: 2
case-max-lines: 0
default: all
Loading