Skip to content

fix: typecheck memory leak #5884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldez merged 1 commit into from
Jun 19, 2025
Merged

fix: typecheck memory leak #5884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: typecheck memory leak
  • Loading branch information
@ldez
ldez committed Jun 18, 2025
commit 6acc49a3c80559b5ed93ab9628f77ac276ae93d9
4 changes: 2 additions & 2 deletions pkg/goanalysis/runner_checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,12 @@ func (act *action) analyze() {
// Report an error if any dependency failures.
var depErrors error
for _, dep := range act.Deps {
if dep.Err != nil {
if dep.Err != nil && errors.Unwrap(dep.Err) != nil {
depErrors = errors.Join(depErrors, errors.Unwrap(dep.Err))
}
}
if depErrors != nil {
act.Err = fmt.Errorf("failed prerequisites: %w", depErrors)
act.Err = errors.Join(depErrors, errors.New("failed prerequisites"))
return
}

Expand Down
Loading