Skip to content

fix: gocritic importshadow checker #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldez merged 5 commits into from
Apr 1, 2025
Merged

fix: gocritic importshadow checker #5673

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8df382c
chore: split wrapper and settingsWrapper
ldez Apr 1, 2025
11ea4ab
chore: remove runOnPackage
ldez Apr 1, 2025
2068605
fix: importShadow
ldez Apr 1, 2025
7c37d1f
chore: lint
ldez Apr 1, 2025
950b770
test: add importShadow test
ldez Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: importShadow
  • Loading branch information
@ldez
ldez committed Apr 1, 2025
commit 20686056e028e08ca76665dd461f184541a5c2c2
11 changes: 11 additions & 0 deletions pkg/golinters/gocritic/gocritic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ func (w *goCriticWrapper) init(logger logutils.Log, settings *config.GoCriticSet

settingsWrapper := newSettingsWrapper(settings, logger)
settingsWrapper.InferEnabledChecks()

// Validate must be after InferEnabledChecks, not before.
// Because it uses gathered information about tags set and finally enabled checks.
if err := settingsWrapper.Validate(); err != nil {
Expand All @@ -113,7 +114,17 @@ func (w *goCriticWrapper) run(pass *analysis.Pass) error {

linterCtx.SetPackageInfo(pass.TypesInfo, pass.Pkg)

needFileInfo := slices.ContainsFunc(enabledCheckers, func(c *gocriticlinter.Checker) bool {
// Related to https://github.com/go-critic/go-critic/blob/440ff466685b41e67d231a1c4a8f5e093374ee93/checkers/importShadow_checker.go#L23
return strings.EqualFold(c.Info.Name, "importShadow")
})

for _, f := range pass.Files {
if needFileInfo {
// Related to https://github.com/go-critic/go-critic/blob/440ff466685b41e67d231a1c4a8f5e093374ee93/checkers/importShadow_checker.go#L23
linterCtx.SetFileInfo(f.Name.Name, f)
}

runOnFile(pass, f, enabledCheckers)
}

Expand Down