fix: the TeamCity inspectionType service message #4573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [Inspection Type](https://www.jetbrains.com/help/teamcity/service-messages.html#Inspection+Type) is used in the TeamCity printer. The message type should be `inspectionType` as the doc specified, but the golangci-lint uses `InspectionType`(capitalized "I"). I'm not sure if it works with previous TeamCity versions, I'm currenly on "TeamCity Enterprise 2023.11.3 (build 147512)" and it doesn't work for me. Changing the `InspectionType` to `inspectionType` did the trick. Update the TeamCity printer to have it align with the specification, and avoid any surprise in the future. Signed-off-by: Mengnan Gong <[email protected]>
|
Hey, thank you for opening your first Pull Request ! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Inspection Type is used in the TeamCity printer. The message type should be
inspectionTypeas the doc specified, but the golangci-lint usesInspectionType(capitalized "I").I'm not sure if it works with previous TeamCity versions, I'm currenly on "TeamCity Enterprise 2023.11.3 (build 147512)" and it doesn't work for me. Changing the
InspectionTypetoinspectionTypedid the trick.Update the TeamCity printer to have it align with the specification, and avoid any surprise in the future.