Skip to content

feat: option to not override severity from linters #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2024
Merged

feat: option to not override severity from linters #4452

merged 1 commit into from
Mar 4, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 4, 2024 •
edited
Loading

This PR has been reverted and replaced by #4472.

The option described in this PR has been removed and replaced by another approach.

previous description 
linters-settings:
  revive:
    severity: error
    rules:
      - name: unexported-return
        disabled: true
      - name: unused-parameter
        severity: warning

severity:
  default-severity: tomato
  keep-linter-severity: true
$ go run ./cmd/golangci-lint run --out-format=checkstyle                            
<?xml version="1.0" encoding="UTF-8"?>

<checkstyle version="5.0">
  <file name="pkg/golinters/stylecheck.go">
    <error column="1" line="14" message="don&#39;t use `init` function" severity="tomato" source="gochecknoinits"></error>
    <error column="31" line="24" message="unused-parameter: parameter &#39;pass&#39; seems to be unused, consider removing or renaming it as _" severity="warning" source="revive"></error>
  </file>
</checkstyle>
exit status 1

Fixes #3111
Closes #4434

@ldez ldez added the enhancement New feature or improvement label Mar 4, 2024
@ldez ldez changed the title feat: option to not override severity feat: option to not override severity from linters Mar 4, 2024
@ldez ldez mentioned this pull request Mar 4, 2024
Closed
@ldez ldez added the area: config Related to .golangci.yml and/or cli options label Mar 4, 2024
@ldez ldez requested a review from alexandear March 4, 2024 16:41
alexandear
alexandear reviewed Mar 4, 2024
View reviewed changes
@ldez ldez merged commit 3d91352 into golangci:master Mar 4, 2024
@ldez ldez deleted the feat/severity-override branch March 4, 2024 19:11
@ldez ldez added this to the next milestone Mar 4, 2024
Antonboom
Antonboom reviewed Mar 6, 2024
View reviewed changes
This was referenced Mar 8, 2024
Closed
Merged
ldez added a commit to ldez/golangci-lint that referenced this pull request Mar 8, 2024
@ldez
Revert "feat: option to not override severity from linters (golangci#…
7abc5ee 
…4452)"

This reverts commit 3d91352.
@ldez ldez mentioned this pull request Mar 8, 2024
Merged
ldez added a commit to ldez/golangci-lint that referenced this pull request Mar 9, 2024
@ldez
Revert "feat: option to not override severity from linters (golangci#…
cdea24f 
…4452)"

This reverts commit 3d91352.
ldez added a commit to ldez/golangci-lint that referenced this pull request Mar 9, 2024
@ldez
Revert "feat: option to not override severity from linters (golangci#…
e69926b 
…4452)"

This reverts commit 3d91352.
ldez added a commit to ldez/golangci-lint that referenced this pull request Mar 11, 2024
@ldez
Revert "feat: option to not override severity from linters (golangci#…
440133c 
…4452)"

This reverts commit 3d91352.
@ldez
Copy link
Member Author

ldez commented Mar 11, 2024

This PR has been reverted and replaced by #4472.

The option described in this PR has been removed and replaced by another approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antonboom Antonboom Antonboom left review comments

@alexandear alexandear alexandear approved these changes

Assignees

No one assigned

Labels

area: config Related to .golangci.yml and/or cli options area: severity enhancement New feature or improvement

Projects

None yet

Milestone

v1.57

Development

Successfully merging this pull request may close these issues.

revive: rules's severity config has no effect

3 participants

@ldez @alexandear @Antonboom