dev: isolate printer code #4435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
approved these changes
Mar 2, 2024
alexandear
reviewed
Mar 2, 2024
Co-authored-by: Oleksandr Redko <[email protected]>
bombsimon
approved these changes
Mar 3, 2024
Antonboom
reviewed
Mar 6, 2024
| } | ||
| } | ||
|
|
||
| func TestPrinter_Print_stderr(t *testing.T) { |
There was a problem hiding this comment.
proposal: t.Parallel for fat tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the continuity of the previous PRs (#4404, #4412, and #4419), the code related to output/printer is moved into the package
printer.Each printer was already in this package but a lot of the code related to build and print was inside the
runcommand.This allows us to add tests to this section.