Skip to content

Conversation

tmzane
Copy link
Contributor

@tmzane tmzane commented Oct 26, 2023

A few options have been added:

  • ContextOnly: enforce using methods that accept a context
  • KeyNamingCase: enforce a single key naming convention

go-simpler/sloglint@v0.1.2...v0.2.0

@ldez
Copy link
Member

ldez commented Oct 26, 2023

Hello,

we use dependabot to update dependencies, and we update the code inside the PR created by dependabot. The update happens once a week by default.
So you don't need to create a PR.

@ldez ldez changed the title build(deps): bump sloglint from 0.1.2 to 0.2.0 build(deps): bump go-simpler.org/sloglint from 0.1.2 to 0.2.0 Oct 26, 2023
@ldez ldez added dependencies Relates to an upstream dependency linter: update version Update version of linter go Pull requests that update Go code labels Oct 26, 2023
@ldez ldez self-requested a review October 26, 2023 18:58
@tmzane
Copy link
Contributor Author

tmzane commented Oct 26, 2023

But I won't have access to dependabot's branch to push the new code, will I?

@ldez
Copy link
Member

ldez commented Oct 26, 2023

But I won't have access to dependabot's branch to push the new code, will I?

You will not but maintainers handle that for you.

@ldez
Copy link
Member

ldez commented Oct 26, 2023

We will accept and merge this PR, there is no major problem.

It was mainly to inform you about the linter update flow.

@tmzane
Copy link
Contributor Author

tmzane commented Oct 26, 2023

Got it, thanks for the info!

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit f17fef3 into golangci:master Nov 5, 2023
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants