Skip to content

Add options to skip caching of folders. #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2021
Merged

Add options to skip caching of folders. #154

merged 1 commit into from
Feb 14, 2021

Conversation

@smyrman
Copy link
Contributor

@smyrman smyrman commented Jan 28, 2021 •
edited
Loading

Fix #153.

  • Add option to skip caching the Go package directory (~/go/pkg).
  • Add option to skip caching the Go build directory (~/.cache/go-build).
  • Update README to mention new options.

@smyrman smyrman force-pushed the skip-cache branch 2 times, most recently from 263fcb3 to e3f3aaa Compare January 28, 2021 11:30
@smyrman
Add options to skip caching of folders.
08d7d77 
Add option to skip caching the Go package directory (~/go/pkg).
Add option to skip caching the Go build directory (~/.cache/go-build).
Update README to mention new options.
@smyrman
Copy link
Contributor Author

smyrman commented Jan 28, 2021 •
edited
Loading

Example output with no cache hit:

image

@smyrman smyrman marked this pull request as ready for review January 28, 2021 11:55
@smyrman
Copy link
Contributor Author

smyrman commented Jan 28, 2021

Example output with cache hit:
image

SVilgelm
SVilgelm approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@SVilgelm SVilgelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you

@SVilgelm
Copy link
Member

SVilgelm commented Feb 14, 2021

Hi @smyrman
thank you for the changes, I'm going to release it in the next release (v2.4.0)

@SVilgelm SVilgelm merged commit 0dd3083 into golangci:master Feb 14, 2021
@SVilgelm SVilgelm mentioned this pull request Feb 14, 2021
Merged
@kprav33n kprav33n mentioned this pull request Mar 5, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Merged
@ldez ldez added the enhancement New feature or request label Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SVilgelm SVilgelm SVilgelm approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow disabeling go mod cache

3 participants

@smyrman @SVilgelm @ldez