fix(release-brancher): use "ci:" (non-releasable) in init #2622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "ci: " suffix in the commit message when it creates a workflow pull request for initializing the protected branch.
suztomo
commented
Sep 29, 2021
Comment on lines
+289
to
+290
| "message": "ci: configure the protected branch", | ||
| "title": "ci: configure the protected branch", |
There was a problem hiding this comment.
This is the effect of this PR.
| // For java-lts type, we want a release through a releasable commit ('feat: ') immediately | ||
| // after creating the protected branch. | ||
| const message = | ||
| (this.releaseType === 'java-lts' ? 'feat' : 'ci') + |
There was a problem hiding this comment.
I think we need to have condition based on the releaseType.
4 tasks
chingor13
approved these changes
Sep 30, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
🤖 I have created a release \*beep\* \*boop\* --- <details><summary>@google-cloud/release-brancher: 1.3.1</summary> ### Bug Fixes * **release-brancher:** use "ci:" (non-releasable) in init ([#2622](https://www.github.com/googleapis/repo-automation-bots/issues/2622)) ([c4b3ac5](https://www.github.com/googleapis/repo-automation-bots/commit/c4b3ac5e50f9579202a614c655e79eaf4bca362e)) </details> This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "ci: " suffix in the commit message when it creates a workflow pull request for initializing the protected branch. This addresses @chingor13 's comment in #2615 (comment)
Fixes #2568 🦕