Skip to content

Conversation

bharadwajvr
Copy link
Contributor

Add a few code snippets to illustrate how to use Spanner Graph functionality in Python. These examples resemble other snippets for how various other Spanner features can be used.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1185 🦕

@bharadwajvr bharadwajvr requested review from a team as code owners August 9, 2024 17:13
@bharadwajvr bharadwajvr requested a review from iennae August 9, 2024 17:13
Copy link

snippet-bot bot commented Aug 9, 2024

Here is the summary of changes.

You are about to add 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 9, 2024
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Aug 9, 2024
@bharadwajvr
Copy link
Contributor Author

I did not find instructions for this in the authoring guide - how do I obtain code coverage information for the new code I've written? There is an ask in the description to verify that " Code coverage does not decrease (if any source code was changed)"

@bharadwajvr
Copy link
Contributor Author

Gentle ping.

@bharadwajvr
Copy link
Contributor Author

A reminder

@harshachinta
Copy link
Contributor

@bharadwajvr Thanks for the PR. Will review it early next week.

@harshachinta
Copy link
Contributor

I did not find instructions for this in the authoring guide - how do I obtain code coverage information for the new code I've written? There is an ask in the description to verify that " Code coverage does not decrease (if any source code was changed)"

Looking at the files changed, there is no source file changes in this PR. So this can be ignored.

@bharadwajvr
Copy link
Contributor Author

@bharadwajvr Thanks for the PR. Will review it early next week.

Thank you @harshachinta

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2024
@harshachinta harshachinta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 26, 2024
@harshachinta
Copy link
Contributor

Adding Do not merge to check the presubmit build status before merging

@harshachinta
Copy link
Contributor

@bharadwajvr
Can you please fix the failing lint
image

@bharadwajvr
Copy link
Contributor Author

bharadwajvr commented Aug 26, 2024

@bharadwajvr Can you please fix the failing lint image

Done. Local run succeeds. @harshachinta

$ flake8 --show-source --builtin=gettext --max-complexity=20 '--exclude=.nox,.cache,env,lib,generated_pb2,*_pb2.py,*_pb2_grpc.py' --ignore=E121,E123,E126,E203,E226,E24,E266,E501,E704,W503,W504,I202 --max-line-length=88
$

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@harshachinta harshachinta enabled auto-merge (squash) August 27, 2024 05:25
@harshachinta harshachinta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@harshachinta harshachinta merged commit f886ebd into googleapis:main Aug 27, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create samples for Cloud Spanner Graph
4 participants