Skip to content

refactor: incorporate will_accept() checks into publish() #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 9, 2020
Merged

refactor: incorporate will_accept() checks into publish() #108

merged 6 commits into from
Jun 9, 2020

Conversation

IlyaFaer
Copy link

Closes #105

@IlyaFaer IlyaFaer added api: pubsub Issues related to the googleapis/python-pubsub API. type: cleanup An internal cleanup or hygiene concern. labels May 28, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2020
IlyaFaer
IlyaFaer commented May 28, 2020
View reviewed changes
@IlyaFaer IlyaFaer requested a review from pradn May 28, 2020 10:56
@IlyaFaer IlyaFaer marked this pull request as ready for review May 28, 2020 10:56
pradn
pradn requested changes May 28, 2020
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! I think we need to retain/add some tests. Otherwise, looks good.

IlyaFaer added 2 commits June 2, 2020 13:27