Skip to content
This repository was archived by the owner on Sep 12, 2025. It is now read-only.

chore: remove redundant code #979

Merged
merged 2 commits into from
Sep 8, 2025
Merged

chore: remove redundant code #979

merged 2 commits into from
Sep 8, 2025

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Sep 5, 2025 •
edited
Loading

The comment below states The DataFormat enum is not exposed in bigquery_storage_v1/types, add it there but it is already part of bigquery_storage_v1/types

python-bigquery-storage/owlbot.py

Lines 79 to 89 in 2a6daa1

# The DataFormat enum is not exposed in bigquery_storage_v1/types, add it there.
assert 1 == s.replace(
library / f"google/cloud/bigquery_storage_{library.name}*/types/__init__.py",
r"from \.stream import \(",
"\\g<0>\n DataFormat,",
)
assert 1 == s.replace(
library / f"google/cloud/bigquery_storage_{library.name}*/types/__init__.py",
r"""["']ReadSession["']""",
'"DataFormat",\n \\g<0>',
)

This code causes DataFormat to appear twice in **/types/__init__.py

python-bigquery-storage/google/cloud/bigquery_storage_v1/types/__init__.py

Lines 71 to 75 in 2a6daa1

"DataFormat",
"ReadSession",
"ReadStream",
"WriteStream",
"DataFormat",

python-bigquery-storage/google/cloud/bigquery_storage_v1beta2/types/__init__.py

Lines 68 to 72 in 2a6daa1

"DataFormat",
"ReadSession",
"ReadStream",
"WriteStream",
"DataFormat",

See the generated code here which shows DataFormat already exists in **/types/__init__.py

https://github.com/googleapis/googleapis-gen/blob/0c329e8511aa92a534987082babc89f9364a341b/google/cloud/bigquery/storage/v1/bigquery-storage-v1-py/google/cloud/bigquery_storage_v1/types/__init__.py#L55

https://github.com/googleapis/googleapis-gen/blob/0c329e8511aa92a534987082babc89f9364a341b/google/cloud/bigquery/storage/v1beta2/bigquery-storage-v1beta2-py/google/cloud/bigquery_storage_v1beta2/types/__init__.py#L53

See related commits in googleapis/google-cloud-python#14361

googleapis/google-cloud-python@e4564dc
googleapis/google-cloud-python@685e1e8

@parthea parthea requested review from a team as code owners September 5, 2025 16:34
@parthea parthea requested a review from Neenu1995 September 5, 2025 16:34
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 5, 2025
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Sep 5, 2025
@parthea parthea assigned Linchin and unassigned Neenu1995 Sep 5, 2025
@Linchin Linchin enabled auto-merge (squash) September 8, 2025 18:20
@Linchin Linchin merged commit 8170d3d into main Sep 8, 2025
29 checks passed
@Linchin Linchin deleted the remove-duplicate-dataformat branch September 8, 2025 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995 Neenu1995 was automatically assigned from googleapis/api-bigquery

1 more reviewer

@Linchin Linchin Linchin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Linchin Linchin

Labels

api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea @Linchin @Neenu1995