Skip to content

feat: add remote vertex model support #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 29, 2023
Merged

feat: add remote vertex model support #237

merged 6 commits into from
Nov 29, 2023

Conversation

GarrettWu
Copy link
Contributor

@GarrettWu GarrettWu commented Nov 29, 2023 •
edited
Loading

b/299356085

@GarrettWu GarrettWu requested review from a team as code owners November 29, 2023 00:13
@GarrettWu GarrettWu requested a review from Genesis929 November 29, 2023 00:13
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 29, 2023
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Nov 29, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Nov 29, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 29, 2023
@GarrettWu GarrettWu requested review from ashleyxuu and shobsi and removed request for Genesis929 November 29, 2023 00:16
ashleyxuu
ashleyxuu reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update docs/template/toc.yml file and docs/reference/bigframe.ml file to auto-sync the docs changes.

bigframes/ml/remote.py
Args:
endpoint (str):
Vertex AI https endpoint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give an example of the endpoints? For example, I saw "https://us-central1-aiplatform.googleapis.com/v1/projects/1084210331973/locations/us-central1/endpoints/3193318217619603456" in your test. Might be give users some hints how to find the endpoints?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.