Skip to content

fix: dtype parameter ineffective in Series/DataFrame construction #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 5, 2025
Merged

fix: dtype parameter ineffective in Series/DataFrame construction #1354

merged 4 commits into from
Feb 5, 2025

Conversation

chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Feb 3, 2025 •
edited
Loading

Corrects an issue where the dtype parameter was not being applied in some cases during Series and DataFrame construction.

  • Fixes internal issue 394086695 and 362738764🦕
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 394086695 and 362738764 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 3, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_dtypebugs branch from c0a3ec0 to df43fe8 Compare February 3, 2025 21:54
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Feb 3, 2025
@chelsea-lin chelsea-lin changed the title fix: dtype parameter ineffective in Series IO fix: dtype parameter ineffective in Series/DataFrame IO Feb 3, 2025
@chelsea-lin chelsea-lin changed the title fix: dtype parameter ineffective in Series/DataFrame IO fix: dtype parameter ineffective in Series/DataFrame construction Feb 3, 2025
@chelsea-lin chelsea-lin marked this pull request as ready for review February 3, 2025 21:59
@chelsea-lin chelsea-lin requested review from a team as code owners February 3, 2025 21:59
@chelsea-lin
Copy link
Contributor Author

test_series_construct_w_dtype_for_array_string fails on system-3-9 but works in python 3.12

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_dtypebugs branch from f0246f7 to 69b2701 Compare February 5, 2025 00:34
tswast
tswast reviewed Feb 5, 2025
View reviewed changes
@chelsea-lin chelsea-lin enabled auto-merge (squash) February 5, 2025 18:24
@chelsea-lin chelsea-lin merged commit b9bdca8 into main Feb 5, 2025
21 of 23 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_dtypebugs branch February 5, 2025 19:14
@release-please release-please bot mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929

Assignees

@shobsi shobsi

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chelsea-lin @tswast @shobsi