Skip to content

feat: support type annotations to supply input and output types to @remote_function decorator #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 25, 2024
Merged

feat: support type annotations to supply input and output types to @remote_function decorator #717

merged 6 commits into from
May 25, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 22, 2024 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
feat: support type annotations to supply input and output types to bpd.remote_function() decorator (#717)
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 336023152
🦕

@tswast tswast requested review from a team as code owners May 22, 2024 19:11
@tswast tswast requested a review from junyazhang May 22, 2024 19:11
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 22, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label May 22, 2024
@tswast
Copy link
Collaborator Author

tswast commented May 22, 2024

Note: I didn't update samples or notebooks. Will wait until this change makes it into a release to update those

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 24, 2024
@tswast tswast enabled auto-merge (squash) May 24, 2024 21:29
@tswast tswast disabled auto-merge May 24, 2024 21:51
@tswast tswast enabled auto-merge (squash) May 24, 2024 23:00
@tswast tswast merged commit 4a12e3c into main May 25, 2024
@tswast tswast deleted the b336023152-remote_function-type-annotations branch May 25, 2024 00:05
@release-please release-please bot mentioned this pull request May 24, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@junyazhang junyazhang junyazhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stevewalker-de stevewalker-de

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @junyazhang @stevewalker-de