Skip to content

samples: tests: Test stdout, not stderr. #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2017
Merged

samples: tests: Test stdout, not stderr. #96

merged 1 commit into from
Nov 28, 2017

Conversation

stephenplusplus
Copy link
Contributor

We've been getting an error on CI, and I think this should fix it.

Error: https://circleci.com/gh/googleapis/nodejs-storage/2149

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 27, 2017
@ghost ghost assigned stephenplusplus Nov 27, 2017
@stephenplusplus stephenplusplus merged commit ec74a68 into googleapis:master Nov 28, 2017
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Nov 28, 2017
@stephenplusplus stephenplusplus deleted the spp--samples-tests-stdoutfix branch November 28, 2017 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

1 more reviewer

@callmehiphop callmehiphop callmehiphop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stephenplusplus stephenplusplus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenplusplus @callmehiphop @googlebot