Skip to content

Conversation

BenWhitehead
Copy link
Collaborator

The initial attempt at this could leak scope and result in new spans being nested incorrectly. This approach attempts to be less clever, but bounds all scopes so there isn't any leaking.

Leaked spans in v2.56.0

image

Fixed spans after this PR

image

Followup to #3255

…zy RPCs such as reads & writes

The initial attempt at this could leak scope and result in new spans being nested incorrectly. This approach attempts to be less clever, but bounds all scopes so there isn't any leaking.

Followup to #3255
@BenWhitehead BenWhitehead requested a review from a team as a code owner September 4, 2025 18:50
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Sep 4, 2025
@BenWhitehead BenWhitehead merged commit 3240f67 into main Sep 4, 2025
25 checks passed
@BenWhitehead BenWhitehead deleted the otel/span/propogation-2 branch September 4, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants