fix: update GrpcStorageImpl#update to support fine-grained update of BucketInfo.labels and BlobInfo.metadata #1843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BucketInfo.labels and BlobInfo.metadata Successor to #1830, whereas this preserves existing behavior rather than introducing a new method. A new set of tests have been added to validate all permutations of modifying metadata/labels.
frankyn
reviewed
Jan 11, 2023
| @@ -331,7 +335,7 @@ public Builder setTimeStorageClassUpdatedOffsetDateTime( | |||
| } | |||
|
|
|||
| /** Sets the blob's user provided metadata. */ | |||
| public abstract Builder setMetadata(Map<String, String> metadata); | |||
| public abstract Builder setMetadata(@Nullable Map<@NonNull String, @Nullable String> metadata); | |||
There was a problem hiding this comment.
If a dev is extended BlobInfo and they overload; they'll need to add @nullable as well IIUC?
There was a problem hiding this comment.
The annotations are optional from the actual runtime standpoint, this is putting a label to the existing behavior that wasn't explicitly expressed anywhere.
frankyn
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #1830, whereas this preserves existing behavior rather than introducing a new method.
A new set of tests have been added to validate all permutations of modifying metadata/labels.