Skip to content

Conversation

frankyn
Copy link
Contributor

@frankyn frankyn commented Feb 12, 2022

Cherry Pick PR #1177 into 2.1.x

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-storage/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Appropriate docs were updated (if necessary)

Fixes #1175  ☕️
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Feb 12, 2022
@frankyn frankyn changed the title fix: cherry pick IAM condition validation PR #1160 fix: cherry pick IAM condition validation PR #1177 Feb 12, 2022
@frankyn frankyn marked this pull request as ready for review February 12, 2022 01:13
@frankyn frankyn requested a review from a team as a code owner February 12, 2022 01:13
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2022
@BenWhitehead BenWhitehead merged commit 9698550 into 2.1.x Feb 15, 2022
@BenWhitehead BenWhitehead deleted the cherry-pick-3 branch February 15, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants