Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

Conversation

stephenplusplus
Copy link
Contributor

RE: googleapis/nodejs-storage#217

This simply makes the deleteConfig() method public, so stale data in the cache file can be removed by a user.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 11, 2019
@stephenplusplus stephenplusplus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2019
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files           1        1           
  Lines         604      604           
  Branches       87       87           
=======================================
  Hits          588      588           
  Misses         15       15           
  Partials        1        1
Impacted Files Coverage Δ
src/index.ts 97.35% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceabbb3...008aac8. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit eb8976a into master Jul 13, 2019
@stephenplusplus stephenplusplus deleted the spp--make-deleteConfig-public branch July 13, 2019 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants