Skip to content

feat(translate)!: make v3 the default client #9498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2019
Merged

feat(translate)!: make v3 the default client #9498

merged 2 commits into from
Oct 23, 2019

Conversation

busunkim96
Copy link
Contributor

No description provided.

@busunkim96 busunkim96 requested a review from nnegrey October 18, 2019 22:58
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2019
nnegrey
nnegrey suggested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question on library versioning

@busunkim96
Copy link
Contributor Author

Cloud build library is not yet merged: #9510

@busunkim96 busunkim96 merged commit bde08e9 into googleapis:master Oct 23, 2019
@busunkim96 busunkim96 deleted the translate-v3-breaking branch October 23, 2019 17:56
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
feat(translate)!: make v3 the default client (#9498)
e3f6bac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nnegrey nnegrey nnegrey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @nnegrey @googlebot