Skip to content

Marshal 'BYTES' and 'TIME' column / paramter types #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 5, 2016
Merged

Marshal 'BYTES' and 'TIME' column / paramter types #2806

merged 8 commits into from
Dec 5, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 5, 2016

Closes #2229.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Dec 5, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2016
daspecster
daspecster reviewed Dec 5, 2016
View reviewed changes
bigquery/google/cloud/bigquery/_helpers.py
@@ -64,9 +77,17 @@ def _datetime_from_json(value, field):
def _date_from_json(value, field):
"""Coerce 'value' to a datetime date, if set or not nullable"""
if _not_null(value, field):
# value will be a string, in YYYY-MM-DD form.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

daspecster
daspecster reviewed Dec 5, 2016
View reviewed changes
bigquery/google/cloud/bigquery/_helpers.py
def _time_from_json(value, field):
"""Coerce 'value' to a datetime date, if set or not nullable"""
if _not_null(value, field):
# value will be a string, in HH:MM:SS form.

This comment was marked as spam.

Sign in to view

dhermes
dhermes approved these changes Dec 5, 2016
View reviewed changes
bigquery/google/cloud/bigquery/_helpers.py
@@ -64,9 +77,17 @@ def _datetime_from_json(value, field):
def _date_from_json(value, field):
"""Coerce 'value' to a datetime date, if set or not nullable"""
if _not_null(value, field):
# value will be a string, in YYYY-MM-DD form.

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor Author

tseaver commented Dec 5, 2016

I will merge as soon as either Circle CI or Travis passes the Py3k fix I just pushed.

@tseaver tseaver mentioned this pull request Dec 5, 2016
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Dec 5, 2016

Travis is showing build failures for docs which don't happen on Circle or on my local machine.

@tseaver tseaver merged commit 6916814 into googleapis:master Dec 5, 2016
@tseaver tseaver deleted the 2229-bigquery-marshal-bytes-time-types branch December 5, 2016 19:42
@dhermes dhermes mentioned this pull request Dec 5, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017