Skip to content

pubsub: make Publisher log less chatty #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2017
Merged

pubsub: make Publisher log less chatty #1749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ && hasBundlingBytes()
if (!messagesBundle.isEmpty()) {
setupDurationBasedPublishAlarm();
} else if (currentAlarmFuture != null) {
logger.log(Level.INFO, "Cancelling alarm");
logger.log(Level.FINER, "Cancelling alarm, no more messages");

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

if (activeAlarm.getAndSet(false)) {
currentAlarmFuture.cancel(false);
}
Expand All @@ -248,7 +248,7 @@ && hasBundlingBytes()
messagesWaiter.incrementPendingMessages(1);

if (bundleToSend != null) {
logger.log(Level.INFO, "Scheduling a bundle for immediate sending.");
logger.log(Level.FINER, "Scheduling a bundle for immediate sending.");

This comment was marked as spam.

Sign in to view

final OutstandingBundle finalBundleToSend = bundleToSend;
executor.execute(
new Runnable() {
Expand All @@ -263,7 +263,7 @@ public void run() {
// be sent in its own bundle immediately.
if (hasBundlingBytes() && messageSize >= getMaxBundleBytes()) {
logger.log(
Level.INFO, "Message exceeds the max bundle bytes, scheduling it for immediate send.");
Level.FINER, "Message exceeds the max bundle bytes, scheduling it for immediate send.");

This comment was marked as spam.

Sign in to view

executor.execute(
new Runnable() {
@Override
Expand All @@ -280,13 +280,13 @@ public void run() {
private void setupDurationBasedPublishAlarm() {
if (!activeAlarm.getAndSet(true)) {
long delayThresholdMs = getBundlingSettings().getDelayThreshold().getMillis();
logger.log(Level.INFO, "Setting up alarm for the next {0} ms.", delayThresholdMs);
logger.log(Level.FINER, "Setting up alarm for the next {0} ms.", delayThresholdMs);

This comment was marked as spam.

Sign in to view

currentAlarmFuture =
executor.schedule(
new Runnable() {
@Override
public void run() {
logger.log(Level.INFO, "Sending messages based on schedule.");
logger.log(Level.FINER, "Sending messages based on schedule.");

This comment was marked as spam.

Sign in to view

activeAlarm.getAndSet(false);
publishAllOutstanding();
}
Expand Down