Add functional methods for disks and Disk class #870

mziccard · 2016-04-07T10:18:53Z

This PR also includes integration tests for disks images and snapshots.

coveralls · 2016-04-07T12:41:32Z

Changes Unknown when pulling f675ee5 on mziccard:compute-disk into * on GoogleCloudPlatform:compute-alpha*.

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Disk.java

+   *     the disk was not found
+   * @throws ComputeException upon failure
+   */
+  public Operation createSnapshot(String snapshot, OperationOption... options) {


aozarov · 2016-04-08T05:45:32Z

Looks good. I only have one question. @ajkannan do you mind to give it another pass and especially look at the tests/docs (which I completely ignored). If not, I will probably have time for a more thorough review tomorrow afternoon.

ajkannan · 2016-04-08T16:28:03Z

Yes, I can give this a pass now.

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Compute.java

+
+    /**
+     * Returns an option to specify the disk's fields to be returned by the RPC call. If this option
+     * is not provided, all disk's fields are returned. {@code DiskOption.fields} can be used to


ajkannan · 2016-04-08T21:39:50Z

Question: is disk resizing something that we don't want to implement right now?

gcloud-java-compute/src/test/java/com/google/gcloud/compute/DiskTest.java

+  private static final SnapshotId SNAPSHOT = SnapshotId.of("project", "snapshot");
+  private static final ImageId IMAGE = ImageId.of("project", "image");
+  private static final String SNAPSHOT_ID = "snapshotId";
+  private static final String IMAGE_ID = "snapshotId";


ajkannan · 2016-04-09T20:48:37Z

Done with my pass.

mziccard · 2016-04-10T22:08:58Z

I fixed all comments. To add resize support I updated the compute dependency which also removed MaintenanceWindow's list from Zone. Fixed that as well.

gcloud-java-compute/src/test/java/com/google/gcloud/compute/it/ITComputeTest.java

+  }
+
+  @Test
+  public void testListDisksAndSnapshots() throws InterruptedException {


coveralls · 2016-04-10T22:12:26Z

Changes Unknown when pulling f6cbc1b on mziccard:compute-disk into * on GoogleCloudPlatform:compute-alpha*.

ajkannan · 2016-04-11T19:47:35Z

MAINTENANCE_WINDOW still exists in the ZoneField enum (in Compute.java) -- is that intentional or should it be removed?

mziccard · 2016-04-11T19:52:23Z

MAINTENANCE_WINDOW still exists in the ZoneField enum (in Compute.java) -- is that intentional or should it be removed?

I forgot, it should be removed.

ajkannan · 2016-04-11T19:59:20Z

LGTM, feel free to merge after removing the field from the ZoneFields.

- Update compute dependency - Add resize method for disks - Udpate zone and remove MaintenanceWindow - make create(Snapshot) throw if disk is not found - Minor fixes to javadoc and tests

coveralls · 2016-04-11T21:35:33Z

Changes Unknown when pulling 3e1ebd9 on mziccard:compute-disk into * on GoogleCloudPlatform:compute-alpha*.

* Add functional methods for disks and Disk class * Refactor Disk functional methods - Update compute dependency - Add resize method for disks - Udpate zone and remove MaintenanceWindow - make create(Snapshot) throw if disk is not found - Minor fixes to javadoc and tests

🤖 I have created a release *beep* *boop* --- ## [3.1.2](googleapis/java-dataproc@v3.1.1...v3.1.2) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#870](googleapis/java-dataproc#870)) ([d738702](googleapis/java-dataproc@d738702)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…21.2 (googleapis#870) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.protobuf:protobuf-java-util](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.1` -> `3.21.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/compatibility-slim/3.21.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java-util/3.21.2/confidence-slim/3.21.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protocolbuffers/protobuf</summary> ### [`v3.21.2`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.1...v3.21.2) [Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.1...v3.21.2) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-monitoring).

🤖 I have created a release *beep* *boop* --- ## [3.3.1](googleapis/java-monitoring@v3.3.0...v3.3.1) (2022-07-01) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#869](googleapis/java-monitoring#869)) ([76f9358](googleapis/java-monitoring@76f9358)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.0 ([#860](googleapis/java-monitoring#860)) ([635c917](googleapis/java-monitoring@635c917)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.1 ([#861](googleapis/java-monitoring#861)) ([44b0239](googleapis/java-monitoring@44b0239)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.2 ([#870](googleapis/java-monitoring#870)) ([976db41](googleapis/java-monitoring@976db41)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.0 (#870) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.0.0` -> `26.1.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/compatibility-slim/26.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/confidence-slim/26.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.4.6](https://togithub.com/googleapis/java-talent/compare/v2.4.5...v2.4.6) (2022-10-05) ### Bug Fixes * update protobuf to v3.21.7 ([e5d6a5f](https://togithub.com/googleapis/java-talent/commit/e5d6a5f8058390444465256440cdefeffc7c992e)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…s to v2.9.2 (#870) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://togithub.com/googleapis/java-common-protos) | `2.9.1` -> `2.9.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-common-protos/2.9.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-common-protos/2.9.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-common-protos/2.9.2/compatibility-slim/2.9.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-common-protos/2.9.2/confidence-slim/2.9.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-common-protos</summary> ### [`v2.9.2`](https://togithub.com/googleapis/java-common-protos/blob/HEAD/CHANGELOG.md#292-httpsgithubcomgoogleapisjava-common-protoscomparev291v292-2022-07-13) [Compare Source](https://togithub.com/googleapis/java-common-protos/compare/v2.9.1...v2.9.2) ##### Bug Fixes - enable longpaths support for windows test ([#1485](https://togithub.com/googleapis/java-common-protos/issues/1485)) ([#386](https://togithub.com/googleapis/java-common-protos/issues/386)) ([fec7bed](https://togithub.com/googleapis/java-common-protos/commit/fec7bedbd0c3ac1d02de851616222b7189e5ed98)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

🤖 I have created a release *beep* *boop* --- ## [2.8.3](googleapis/java-core@v2.8.2...v2.8.3) (2022-07-26) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v2 ([#868](googleapis/java-core#868)) ([fe7991d](googleapis/java-core@fe7991d)) * update dependency com.google.api:gax-bom to v2.18.4 ([#864](googleapis/java-core#864)) ([d4a8501](googleapis/java-core@d4a8501)) * update dependency com.google.api:gax-bom to v2.18.5 ([#876](googleapis/java-core#876)) ([e2c0c13](googleapis/java-core@e2c0c13)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.9.2 ([#870](googleapis/java-core#870)) ([adf5af4](googleapis/java-core@adf5af4)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.5.2 ([#865](googleapis/java-core#865)) ([5dad1ea](googleapis/java-core@5dad1ea)) * update dependency com.google.auth:google-auth-library-bom to v1.8.1 ([#856](googleapis/java-core#856)) ([bb58609](googleapis/java-core@bb58609)) * update dependency com.google.http-client:google-http-client-bom to v1.42.2 ([#871](googleapis/java-core#871)) ([341b04e](googleapis/java-core@341b04e)) * update dependency com.google.protobuf:protobuf-bom to v3.21.3 ([#874](googleapis/java-core#874)) ([efe8c28](googleapis/java-core@efe8c28)) * update dependency com.google.protobuf:protobuf-bom to v3.21.4 ([#877](googleapis/java-core#877)) ([25bea6c](googleapis/java-core@25bea6c)) * update dependency io.grpc:grpc-bom to v1.48.0 ([#873](googleapis/java-core#873)) ([8bfee63](googleapis/java-core@8bfee63)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

mziccard added the api: compute Issues related to the Compute Engine API. label Apr 7, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2016

Add functional methods for disks and Disk class

f675ee5

mziccard force-pushed the compute-disk branch from ff49083 to f675ee5 Compare April 7, 2016 12:36

aozarov reviewed Apr 8, 2016
View reviewed changes

ajkannan reviewed Apr 8, 2016
View reviewed changes

mziccard reviewed Apr 10, 2016
View reviewed changes

gcloud-java-compute/src/test/java/com/google/gcloud/compute/it/ITComputeTest.java

}

@Test

public void testListDisksAndSnapshots() throws InterruptedException {

This comment was marked as spam.

Sign in to view

Refactor Disk functional methods

3e1ebd9

- Update compute dependency - Add resize method for disks - Udpate zone and remove MaintenanceWindow - make create(Snapshot) throw if disk is not found - Minor fixes to javadoc and tests

mziccard force-pushed the compute-disk branch from f6cbc1b to 3e1ebd9 Compare April 11, 2016 21:11

mziccard merged commit 5486d53 into googleapis:compute-alpha Apr 11, 2016

github-actions bot pushed a commit that referenced this pull request Jul 14, 2022

chore(main): release 2.8.0 (#870)

3458842

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Add functional methods for disks and Disk class #870

Add functional methods for disks and Disk class #870

Uh oh!

Conversation

mziccard commented Apr 7, 2016

Uh oh!

coveralls commented Apr 7, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Apr 8, 2016

Uh oh!

ajkannan commented Apr 8, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ajkannan commented Apr 8, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

ajkannan commented Apr 9, 2016

Uh oh!

mziccard commented Apr 10, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Apr 10, 2016

Uh oh!

ajkannan commented Apr 11, 2016

Uh oh!

mziccard commented Apr 11, 2016

Uh oh!

ajkannan commented Apr 11, 2016

Uh oh!

coveralls commented Apr 11, 2016

Uh oh!

Uh oh!