Add query request and query response classes and tests #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Ehi guys, thanks for the feedback. I fixed all comments and answered the open questions. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
- Add better javadoc and snippet to QueryResponse - Use primitive boolean for jobComplete - Add test for NPE in QueryRequestTests - Add QueryRequest and QueryResponse to SerializationTest
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks great! I have few more questions/nits. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
… list, add hasErrors
|
c6e53c8 fixes latest comments and makes checkstyle happy |
aozarov
added a commit
that referenced
this pull request
Dec 14, 2015
Add query request and query response classes and tests
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
Source-Link: googleapis/synthtool@7a220e2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
…onfig to v1.4.0 (#452) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.3.3` -> `1.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.4.0`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​140-httpsgithubcomgoogleapisjava-shared-configcomparev133v140-2022-04-28) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.3.3...v1.4.0) ##### Features - **java:** remove native image module ([#​471](https://togithub.com/googleapis/java-shared-config/issues/471)) ([7fcba01](https://togithub.com/googleapis/java-shared-config/commit/7fcba016b3138d7beaa4e962853f9bc80f59438c)) ##### [1.3.3](https://togithub.com/googleapis/java-shared-config/compare/v1.3.2...v1.3.3) (2022-04-19) ##### Bug Fixes - **java:** remove protobuf feature from native profile ([#​461](https://togithub.com/googleapis/java-shared-config/issues/461)) ([ffd07cb](https://togithub.com/googleapis/java-shared-config/commit/ffd07cb18ee7d45d4daee1d9ea6f6d321fdca874)) ##### Dependencies - update dependency com.google.cloud:native-image-support to v0.12.11 ([#​459](https://togithub.com/googleapis/java-shared-config/issues/459)) ([d20008d](https://togithub.com/googleapis/java-shared-config/commit/d20008df15209708fdf9d06828b567778190f4d0)) - update dependency com.google.cloud:native-image-support to v0.13.1 ([#​465](https://togithub.com/googleapis/java-shared-config/issues/465)) ([b202064](https://togithub.com/googleapis/java-shared-config/commit/b2020648816feb4740ad70acedfed470d7da5bcf)) ##### [1.3.2](https://togithub.com/googleapis/java-shared-config/compare/v1.3.1...v1.3.2) (2022-03-28) ##### Dependencies - revert google-java-format to 1.7 ([#​453](https://togithub.com/googleapis/java-shared-config/issues/453)) ([cbc777f](https://togithub.com/googleapis/java-shared-config/commit/cbc777f3e9ab75edb6fa2e0268a7446ae4111725)) ##### [1.3.1](https://togithub.com/googleapis/java-shared-config/compare/v1.3.0...v1.3.1) (2022-03-25) ##### Dependencies - update dependency com.google.cloud:native-image-support to v0.12.10 ([#​443](https://togithub.com/googleapis/java-shared-config/issues/443)) ([5b39d5e](https://togithub.com/googleapis/java-shared-config/commit/5b39d5ee15121f052226ff873b6ab101e9c71de5)) - update dependency com.google.googlejavaformat:google-java-format to v1.15.0 ([#​426](https://togithub.com/googleapis/java-shared-config/issues/426)) ([4c3c4b6](https://togithub.com/googleapis/java-shared-config/commit/4c3c4b66129632181e6bc363a0ecccf4f5aac914)) - update dependency org.graalvm.buildtools:junit-platform-native to v0.9.11 ([#​448](https://togithub.com/googleapis/java-shared-config/issues/448)) ([f7f518e](https://togithub.com/googleapis/java-shared-config/commit/f7f518e87d1d9feb9ac54d7c099f97d8751ee3da)) - update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.11 ([#​449](https://togithub.com/googleapis/java-shared-config/issues/449)) ([3e1c0b5](https://togithub.com/googleapis/java-shared-config/commit/3e1c0b5a1d2f4a0db88c06a0d683ed90cbc745e2)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-workflows).
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
…onfig to v1.5.3 (#452) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.1` -> `1.5.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.3`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​153-httpsgithubcomgoogleapisjava-shared-configcomparev152v153-2022-07-27) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.2...v1.5.3) ##### Dependencies - update dependency org.junit.vintage:junit-vintage-engine to v5.9.0 ([#​497](https://togithub.com/googleapis/java-shared-config/issues/497)) ([1fc6ab4](https://togithub.com/googleapis/java-shared-config/commit/1fc6ab445624cd4f9c8b161d109f346a9e5ed09a)) - Update doclet to latest version 1.6.0 ([38fb7c3](https://togithub.com/googleapis/java-shared-config/commit/38fb7c3957fb6c9b2da10f9e463cc93a8b80a3a4)) ### [`v1.5.2`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​152-httpsgithubcomgoogleapisjava-shared-configcomparev151v152-2022-07-25) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.1...v1.5.2) ##### Dependencies - update dependency com.puppycrawl.tools:checkstyle to v10 ([#​435](https://togithub.com/googleapis/java-shared-config/issues/435)) ([bfc8ce1](https://togithub.com/googleapis/java-shared-config/commit/bfc8ce1deca6292147d002d3afe22a09840aa5d6)) - update dependency org.graalvm.buildtools:junit-platform-native to v0.9.13 ([#​488](https://togithub.com/googleapis/java-shared-config/issues/488)) ([39b91ee](https://togithub.com/googleapis/java-shared-config/commit/39b91ee1283f0a5fbbe63e8bfd1ec97ab4ab377e)) - update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.13 ([#​489](https://togithub.com/googleapis/java-shared-config/issues/489)) ([cc3bcfa](https://togithub.com/googleapis/java-shared-config/commit/cc3bcfa2d6717441a8d5b5048fa78c2cf7aabf2b)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-functions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
…admin to v0.13.1 (#452) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.analytics:google-analytics-admin](https://togithub.com/googleapis/java-analytics-admin) | `0.13.0` -> `0.13.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-analytics-admin</summary> ### [`v0.13.1`](https://togithub.com/googleapis/java-analytics-admin/blob/HEAD/CHANGELOG.md#​0131-httpsgithubcomgoogleapisjava-analytics-admincomparev0130v0131-2022-09-08) [Compare Source](https://togithub.com/googleapis/java-analytics-admin/compare/v0.13.0...v0.13.1) ##### Dependencies - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#​449](https://togithub.com/googleapis/java-analytics-admin/issues/449)) ([8c5f1da](https://togithub.com/googleapis/java-analytics-admin/commit/8c5f1da3106dd990fa815ce2bf3ab4f63389fd82)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-analytics-admin). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC4yIn0=-->
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jinja2](https://palletsprojects.com/p/jinja/) ([changelog](https://jinja.palletsprojects.com/changes/)) | `==3.0.3` -> `==3.1.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ## [1.6.2](https://togithub.com/googleapis/java-iam/compare/v1.6.1...v1.6.2) (2022-10-02) ### Documentation * **samples:** Update package names to match v2 ([#424](https://togithub.com/googleapis/java-iam/issues/424)) ([3a4392a](https://togithub.com/googleapis/java-iam/commit/3a4392af5d222d349b2fb8352c041b7889be97b5)) ### Dependencies * Update dependency cachetools to v5 ([#459](https://togithub.com/googleapis/java-iam/issues/459)) ([89ea28b](https://togithub.com/googleapis/java-iam/commit/89ea28b2d57b4bdb11b8d847af313c63c8023146)) * Update dependency certifi to v2022.9.24 ([#440](https://togithub.com/googleapis/java-iam/issues/440)) ([de6c438](https://togithub.com/googleapis/java-iam/commit/de6c438b7709e71bdcc2c1c47702b808f828a42f)) * Update dependency charset-normalizer to v2.1.1 ([#444](https://togithub.com/googleapis/java-iam/issues/444)) ([5715206](https://togithub.com/googleapis/java-iam/commit/57152061f264629aa0f09f2602abf6fe3b242945)) * Update dependency click to v8.1.3 ([#445](https://togithub.com/googleapis/java-iam/issues/445)) ([189a5c4](https://togithub.com/googleapis/java-iam/commit/189a5c4102bd6b9f4fbfc252a67019a7c5e23ee3)) * Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220911-2.0.0 ([#435](https://togithub.com/googleapis/java-iam/issues/435)) ([5d415a9](https://togithub.com/googleapis/java-iam/commit/5d415a98f4e7cede137b57e048ec70c21ea8376d)) * Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220925-2.0.0 ([#439](https://togithub.com/googleapis/java-iam/issues/439)) ([b17765b](https://togithub.com/googleapis/java-iam/commit/b17765b5e897bcef60aeef56ed2524b418f73b65)) * Update dependency com.google.cloud:google-iam-policy to v1.6.1 ([#434](https://togithub.com/googleapis/java-iam/issues/434)) ([18d4bc0](https://togithub.com/googleapis/java-iam/commit/18d4bc0cd7341123d00eeb5fa15606d058f12fa6)) * Update dependency com.google.protobuf:protobuf-java to v3.21.7 ([#463](https://togithub.com/googleapis/java-iam/issues/463)) ([8ad215f](https://togithub.com/googleapis/java-iam/commit/8ad215f4543f7ffcd891ed6e1b202fe1ddccd86f)) * Update dependency gcp-releasetool to v1.8.8 ([#441](https://togithub.com/googleapis/java-iam/issues/441)) ([31fec95](https://togithub.com/googleapis/java-iam/commit/31fec95f348f55c98dab665bec47d88f396a9611)) * Update dependency google-api-core to v2.10.1 ([#446](https://togithub.com/googleapis/java-iam/issues/446)) ([50d8221](https://togithub.com/googleapis/java-iam/commit/50d82218cb3056bb49173d7f5d4e7b0070717b0f)) * Update dependency google-auth to v2.12.0 ([#447](https://togithub.com/googleapis/java-iam/issues/447)) ([97b4c23](https://togithub.com/googleapis/java-iam/commit/97b4c236276d27be1e290334573ec6897c9e67c9)) * Update dependency google-cloud-core to v2.3.2 ([#442](https://togithub.com/googleapis/java-iam/issues/442)) ([00adc9a](https://togithub.com/googleapis/java-iam/commit/00adc9a8bf225a4c3d1509f9e6778ad10dd16e2e)) * Update dependency google-cloud-storage to v2.5.0 ([#448](https://togithub.com/googleapis/java-iam/issues/448)) ([df5cf74](https://togithub.com/googleapis/java-iam/commit/df5cf74ee883b7f4d99ce9654fcdd6a4670cc98a)) * Update dependency google-crc32c to v1.5.0 ([#449](https://togithub.com/googleapis/java-iam/issues/449)) ([a2f7304](https://togithub.com/googleapis/java-iam/commit/a2f7304a602b4621f43d4b3966586e0a7e1a7a2d)) * Update dependency googleapis-common-protos to v1.56.4 ([#443](https://togithub.com/googleapis/java-iam/issues/443)) ([c64de5a](https://togithub.com/googleapis/java-iam/commit/c64de5a5b2f3fcd9e17ed4963e586aaf0a1209ba)) * Update dependency importlib-metadata to v4.12.0 ([#450](https://togithub.com/googleapis/java-iam/issues/450)) ([e8607ce](https://togithub.com/googleapis/java-iam/commit/e8607ce4d1c6b202726b185560920c742e056a30)) * Update dependency io.grpc:grpc-protobuf to v1.49.2 ([#464](https://togithub.com/googleapis/java-iam/issues/464)) ([0d24035](https://togithub.com/googleapis/java-iam/commit/0d2403530080668411981679ec01801d5e756e03)) * Update dependency io.grpc:grpc-stub to v1.49.2 ([#465](https://togithub.com/googleapis/java-iam/issues/465)) ([2b67643](https://togithub.com/googleapis/java-iam/commit/2b67643239cf9cf617ddd3d15d176fbdb574d15e)) * Update dependency jeepney to v0.8.0 ([#451](https://togithub.com/googleapis/java-iam/issues/451)) ([56c8f86](https://togithub.com/googleapis/java-iam/commit/56c8f86e437f49636edd5673b4336def947de475)) * Update dependency jinja2 to v3.1.2 ([#452](https://togithub.com/googleapis/java-iam/issues/452)) ([0ebc062](https://togithub.com/googleapis/java-iam/commit/0ebc06212f4dc10f8724f35705d1db9ab148beac)) * Update dependency markupsafe to v2.1.1 ([#454](https://togithub.com/googleapis/java-iam/issues/454)) ([93bd5ec](https://togithub.com/googleapis/java-iam/commit/93bd5ec7183cf306e4956261321038b923861276)) * Update dependency protobuf to v3.20.2 ([#455](https://togithub.com/googleapis/java-iam/issues/455)) ([fb47671](https://togithub.com/googleapis/java-iam/commit/fb47671168b256e9b76ecc16e52cf0674cbefce7)) * Update dependency protobuf to v4 ([#460](https://togithub.com/googleapis/java-iam/issues/460)) ([cb9637c](https://togithub.com/googleapis/java-iam/commit/cb9637ce2ed8976deda7a146a3df738f6afd158c)) * Update dependency pyjwt to v2.5.0 ([#461](https://togithub.com/googleapis/java-iam/issues/461)) ([2d696a0](https://togithub.com/googleapis/java-iam/commit/2d696a04f036369b25a3dceb29f8f1b855136890)) * Update dependency requests to v2.28.1 ([#456](https://togithub.com/googleapis/java-iam/issues/456)) ([b023d05](https://togithub.com/googleapis/java-iam/commit/b023d05d096ae796573c488869682c45f1de57b2)) * Update dependency typing-extensions to v4.3.0 ([#457](https://togithub.com/googleapis/java-iam/issues/457)) ([53a369c](https://togithub.com/googleapis/java-iam/commit/53a369c5f157bcfb2752c6b6503d2f5e76c226b8)) * Update dependency zipp to v3.8.1 ([#458](https://togithub.com/googleapis/java-iam/issues/458)) ([39ea408](https://togithub.com/googleapis/java-iam/commit/39ea4087f4b72a57ee09d6f312d05f7607d89bfb)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds classes for Query Requests and Query Responses:
QueryRequestis used to run queries "on the fly" Jobs: queryQueryResponseis used to both hold the result of queries run on the fly (Jobs: query) and to hold the result of query jobs (Jobs: getQueryResults)Remarks
QueryResponsehas nofromPbmethod as it is initialized through the builder inside theBigQueryServiceImplclass. This is so because:Page<List<FieldValue>> rowsQueryResponseis created from 2 pb classes: QueryResponse and GetQueryResultsResponseI preferred to handle the creation inside
BigQueryServiceImplrather than having afromPbmethod with more parameters.