feat: fix snippets and client versions for multi-path APIs #12756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were effectively left over from two PRs which crossed.
557044f to
2143177
Compare
Some APIs have multiple paths with nested elements. For example, in Spanner we have: - google/spanner/v1 - google/spanner/adapter/v1 - google/spanner/admin/database/v1 - google/spanner/admin/instance/v1 - google/spanner/executor/v1 Subdirectories are created effectively relative to the module name, both for clients and snippets. This commit fixes the version handling for both clients and snippets, for the postprocessor. This commit does not change the snippet metadata handling for the release command; that will be handled in a separate commit (refactoring much of this code into module.go).
2143177 to
dd7c803
Compare
Contributor
Author
|
Closing in favor of #12794. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one new commit on top of #12775.
With this in place, the Spanner diff is only README.md and a "generated by" comment in internal/version.go (as well as go.mod/go.sum).
Note that the release command currently has its own snippet metadata handling code, which is slightly different (basically finding files recursively, instead of predicting the presence of specific files). We'll want to refactor all of the snippet metadata handling code to remove duplication - we should figure out which approach to use.