fix: make gRPC auth plugin non-blocking + add default timeout value f… #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or requests transport This commit includes the following changes: - `transport.grpc.AuthMetadataPlugin` is now non-blocking as gRPC requires - `transport.requests.Request` now has a default timeout value of 120 seconds so that token refreshing will not be stuck Resolves: #351
busunkim96
approved these changes
Nov 21, 2019
|
Please merge when you're ready. The release-please bot should open up a PR soon afterwards that you can also review and merge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or requests transport
This commit includes the following changes:
transport.grpc.AuthMetadataPluginis now non-blocking as gRPC requirestransport.requests.Requestnow has a default timeout value of 120 seconds so that token refreshing will not be stuckResolves: #351