Skip to content

fix: make gRPC auth plugin non-blocking + add default timeout value for transport #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: make gRPC auth plugin non-blocking + add default timeout value for transport #389

wants to merge 1 commit into from

Conversation

michaelawyu
Copy link
Contributor

This PR includes the following changes:

  • transport.gprc.AuthMetadataPlugin is now non-blocking as gRPC requires
  • transport.requests.Request now has a default timeout value of 120 seconds so that token refreshing will not be stuck

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2019
@michaelawyu michaelawyu changed the title Fixed #351 fix: make gRPC auth plugin non-blocking + add default timeout value for transport Nov 20, 2019
@michaelawyu michaelawyu mentioned this pull request Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelawyu @googlebot