Skip to content

feat: Retry behavior #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 22, 2022
Merged

feat: Retry behavior #1113

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f6ee870
chore: Refrefsh system test creds.
clundin25 Aug 5, 2022
676d9e2
feat: Retry behavior
clundin25 Aug 19, 2022
92f6c21
Update license for tests/test_exceptions.py
clundin25 Aug 27, 2022
56bab8c
Merge branch 'main' into property-retry
sai-sunder-s Sep 1, 2022
b282743
Merge branch 'main' into property-retry
clundin25 Sep 1, 2022
b2ebcbc
s/should_retry/can_retry/
clundin25 Sep 1, 2022
27ff428
Merge branch 'main' into property-retry
clundin25 Sep 2, 2022
7863cc6
PR feedback. Add temporarily_unavailable as a retryable status_code.
clundin25 Sep 6, 2022
6c4a837
Merge remote-tracking branch 'carl/refresh' into property-retry
clundin25 Sep 6, 2022
f04a1bb
PR Feedback
clundin25 Sep 7, 2022
78b1bf9
Merge remote-tracking branch 'origin/main' into property-retry
clundin25 Sep 13, 2022
00f17ed
chore: Refresh system test creds.
clundin25 Sep 13, 2022
db8f1ea
PR feedback.
clundin25 Sep 13, 2022
60904a8
PR feedback.
clundin25 Sep 14, 2022
2cb8d68
chore: Refresh system test creds.
clundin25 Sep 14, 2022
984580f
PR feedback.
clundin25 Sep 22, 2022
bcbe828
Merge remote-tracking branch 'origin/main' into property-retry
clundin25 Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PR feedback. Add temporarily_unavailable as a retryable status_code.
  • Loading branch information
@clundin25
clundin25 committed Sep 6, 2022
commit 7863cc6dd266b82495c3bc34f4accf3e700d25c2
2 changes: 1 addition & 1 deletion google/oauth2/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def _can_retry(status_code, response_data):

# Per Oauth 2.0 RFC https://www.rfc-editor.org/rfc/rfc6749.html#section-4.1.2.1
# This is needed because a redirect will not return a 500 status code.
retryable_error_descriptions = {"internal_failure", "server_error"}
retryable_error_descriptions = {"internal_failure", "server_error", "temporarily_unavailable"}

if any(e in retryable_error_descriptions for e in (error_code, error_desc)):
return True
Expand Down