fix: prevent nil pointer dereference panic in newAPIError function #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newAPIError function was causing nil pointer dereference panics when the API returned valid JSON that didn't match the expected error format (e.g., missing 'error' field or 'error: null'). This happened because the code would unmarshal JSON successfully but then dereference a nil ErrorInfo pointer. Add explicit nil check before dereferencing ErrorInfo to prevent panics and provide meaningful error messages for unexpected response formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
newAPIErrorfunction inapi_client.gohas improper error handling that can cause nil pointer dereference panics.When the API returns valid JSON that doesn't match the expected
responseWithErrorformat (e.g., missing error field orerror: null), the JSON unmarshaling still succeeds but leavesErrorInfoasnil. The code then dereferences this nil pointer with*respWithError.ErrorInfo, causing a "invalid memory address or nil pointer dereference" panic.Failure Cases
{"some_field": "value"}(valid JSON, no error field). JSON unmarshaling succeeds → ErrorInfo is nil. Code executesreturn *respWithError.ErrorInfo→ nil pointer dereference panic{"error": null, "other": "data"}(valid JSON, explicit null error). JSON unmarshaling succeeds → ErrorInfo is nil. Code executesreturn *respWithError.ErrorInfo→ nil pointer dereference panicFix
Add explicit nil check before dereferencing
ErrorInfo