Skip to content

Conversation

@jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Nov 28, 2025

Re-exposes ios NavModule.h and INavigationCallback.h for driver-sdk needs.
Exports headers needed by the CarPlay support.

BREAKING CHANGE:
The iOS package’s header_dir property has been changed to "ReactNativeGoogleMapsNavigation", which is a breaking change for projects that import headers directly from this package

Fixes: #503

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation
  • I added new tests to check the change I am making
  • All existing and new tests are passing.

@jokerttu jokerttu changed the title fix: re-expose public header files for driver SDK fix: re-expose public iOS header files for driver SDK Nov 28, 2025
@jokerttu jokerttu changed the title fix: re-expose public iOS header files for driver SDK fix: re-expose public iOS header files for Driver SDK Nov 28, 2025
@jokerttu jokerttu changed the title fix: re-expose public iOS header files for Driver SDK fix: re-expose public iOS header files Nov 28, 2025
Copy link
Contributor

@illuminati1911 illuminati1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Make sure the carplay target builds with these changes.

@jokerttu
Copy link
Contributor Author

Looks good. Make sure the carplay target builds with these changes.

Will land this after all features tested against Driver SDK changes.

@jokerttu jokerttu merged commit 00c4635 into main Dec 1, 2025
12 checks passed
@jokerttu jokerttu deleted the fix/re-expose-public-header-files-for-driver-sdk branch December 1, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [iOS] All headers marked as private breaking compatibility with react-native-driver-sdk

3 participants