-
Notifications
You must be signed in to change notification settings - Fork 36
parallelization changes #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pkaushik-pythian The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @pkaushik-pythian. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Attaching gist below: |
The non-Terraform tests seem to be failing because on parse errors of the generated inventory:
|
/retest |
install-oracle.sh
Outdated
' "$file" | ||
} | ||
|
||
ensure_workload_agent_dir() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Why is this function necessary?
The google-cloud-workload-agent.rpm installation already creates this directory to place the default configuration.json file within it.
Also, it appears the function is designed to run only when INSTALL_WORKLOAD_AGENT is not "true". what is the scenario in which this directory is required without the agent itself being installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, it wasn’t necessary it was only added earlier because our presubmit tests were failing. Now that the tests have passed, I’ve removed it.
Created the script in 3 phases introduced in install-oracle.sh:
Phase 1: Software install and host prepare runs both on Primary and standby nodes
Phase 2: Primary database is created
Phase 3: Database is copied to standbys